742573 - Remove fullscreen button from controls in top level audio element

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Reuben Morais [:reuben]]

There shouldn't be a fullscreen button for top level audio elements.

Comment 1

[Reuben Morais [:reuben]]

Attachment: Set up fullscreen state after we have enough data to do it properly

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 728322 [details] [diff] [review]
Set up fullscreen state after we have enough data to do it properly

This will work sometimes, but for a complete fix you'll want to add a call in the |loadedmetadata| handler too... If the binding happens to attach before we've loaded enough of the media from the network, we won't yet know in setupInitialState() if it's audio-only or not.

I also wonder a bit about having adjustControlSize() interact better with this, but that's fodder for some other bug.

This might be of help for testing: http://dolske.net/mozilla/tests/video/slowsend.php?stallat=0&stallfor=5

I should probably add an audio version...

Comment 3

[Justin Dolske [:Dolske]]

http://dolske.net/mozilla/tests/video/slowsend.php?stallat=0&stallfor=3&audioonly

Comment 4

[Reuben Morais [:reuben]]

This was probably fixed in a different bug.

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Still reproduces on Firefox 24 beta 2 (build ID: 20130805030205).

Using the link from comment 3, the fullscreen button is still shown.

Comment 6

[Cornel Ionce [:noni] [Hubs QA]]

Sorry, wrong build ID pasted in previous comment.
The correct one is 20130812173056.

Comment 7

[Reuben Morais [:reuben]]

WORKSFORME on 87c1796bc46c. Are you sure you waited for the audio to actually load before checking? Alternatively, use http://dolske.net/mozilla/tests/video/slowsend.php?audioonly

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

This issue still reproduces on the latest Beta and Aurora builds.

The fix for this is only landed on Nightly, I've checked with the latest build and indeed, the fullscreen button is removed there.

Comment 9

[Reuben Morais [:reuben]]

Ah, okay. Thanks for checking :)