Closed
Bug 742573
Opened 12 years ago
Closed 11 years ago
Remove fullscreen button from controls in top level audio element
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: reuben, Assigned: reuben)
Details
Attachments
(1 file)
2.25 KB,
patch
|
Dolske
:
review-
|
Details | Diff | Splinter Review |
There shouldn't be a fullscreen button for top level audio elements.
Assignee | ||
Comment 1•11 years ago
|
||
Comment 2•11 years ago
|
||
Comment on attachment 728322 [details] [diff] [review] Set up fullscreen state after we have enough data to do it properly This will work sometimes, but for a complete fix you'll want to add a call in the |loadedmetadata| handler too... If the binding happens to attach before we've loaded enough of the media from the network, we won't yet know in setupInitialState() if it's audio-only or not. I also wonder a bit about having adjustControlSize() interact better with this, but that's fodder for some other bug. This might be of help for testing: http://dolske.net/mozilla/tests/video/slowsend.php?stallat=0&stallfor=5 I should probably add an audio version...
Attachment #728322 -
Flags: review?(dolske) → review-
Comment 3•11 years ago
|
||
http://dolske.net/mozilla/tests/video/slowsend.php?stallat=0&stallfor=3&audioonly
Assignee | ||
Comment 4•11 years ago
|
||
This was probably fixed in a different bug.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Comment 5•11 years ago
|
||
Still reproduces on Firefox 24 beta 2 (build ID: 20130805030205). Using the link from comment 3, the fullscreen button is still shown.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment 6•11 years ago
|
||
Sorry, wrong build ID pasted in previous comment. The correct one is 20130812173056.
Assignee | ||
Comment 7•11 years ago
|
||
WORKSFORME on 87c1796bc46c. Are you sure you waited for the audio to actually load before checking? Alternatively, use http://dolske.net/mozilla/tests/video/slowsend.php?audioonly
Flags: needinfo?(cornel.ionce)
Comment 8•11 years ago
|
||
This issue still reproduces on the latest Beta and Aurora builds. The fix for this is only landed on Nightly, I've checked with the latest build and indeed, the fullscreen button is removed there.
Flags: needinfo?(cornel.ionce)
Assignee | ||
Comment 9•11 years ago
|
||
Ah, okay. Thanks for checking :)
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•