742581 - nsStyleCoord::GetCoordValue() signature is inconsistent (nscoord vs PRInt32)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

I just noticed that the method-signature for nsStyleCoord::GetCoordValue doesn't match, between the function declaration & the function definition.  (nscoord vs PRInt32)

Relevant code:
> 90  class nsStyleCoord {
[...]
> 162   nscoord     GetCoordValue() const;
[...]
> 185 };
[...]
> 290 inline PRInt32 nsStyleCoord::GetCoordValue() const
> 291 {
> 292   NS_ASSERTION((mUnit == eStyleUnit_Coord), "not a coord value");
> 293   if (mUnit == eStyleUnit_Coord) {
> 294     return mValue.mInt;
> 295   }
> 296   return 0;
> 297 }

Of course, nscoord and PRInt32 end up evaluating to the same type, but we should make that consistent.

Comment 1

[Daniel Holbert [:dholbert]]

This actually dates back to the original version of this file in CVS, from 1998, it looks like:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/style/nsStyleCoord.h&rev=3.1

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

This changes the definition to use "nscoord" (to match the function declaration).

This also makes it symmetric with SetCoordValue, which takes an nscoord-typed argument.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 613017 [details] [diff] [review]
fix

r=dbaron

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be20d1f8c8a3

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/be20d1f8c8a3