The default bug view has changed. See this FAQ.

Allow indexedDB parent directory to not be the default profile directory

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fabrice, Unassigned)

Tracking

unspecified
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

1.69 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
Created attachment 612453 [details] [diff] [review]
Use the "indexedDBPDir" directory

In b2g we will preload some indexedDB databases (eg. the settings db), like we preload the offline cache and the mozApps data. This happens at build time, before the first run of gecko, so we don't have yet a profile directory.
(Reporter)

Updated

5 years ago
Attachment #612453 - Flags: review?(khuey)
Attachment #612453 - Flags: review?(khuey) → review?(bent.mozilla)
Comment on attachment 612453 [details] [diff] [review]
Use the "indexedDBPDir" directory

Review of attachment 612453 [details] [diff] [review]:
-----------------------------------------------------------------

Hm... If this is just a build thing can we just use an environment variable rather than adding a new directory key?
(Reporter)

Comment 2

5 years ago
It's not only at build time. We expect data to be there at runtime, and we don't have the profile directory ready before first run.
Comment on attachment 612453 [details] [diff] [review]
Use the "indexedDBPDir" directory

Review of attachment 612453 [details] [diff] [review]:
-----------------------------------------------------------------

Ok!
Attachment #612453 - Flags: review?(bent.mozilla) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/28cfc474ab58
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/b87dcc5e00db - so far only Mac has finished debug xpcshell runs, but there you're failing 54 tests:

https://tbpl.mozilla.org/php/getParsedLog.php?id=11330849&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=11330668&tree=Mozilla-Inbound
https://hg.mozilla.org/mozilla-central/rev/28cfc474ab58
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Backed out: https://hg.mozilla.org/mozilla-central/rev/b87dcc5e00db
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 634616 [details] [diff] [review]
patch

Rebased.
Attachment #612453 - Attachment is obsolete: true
Blocks: 766375
I pushed to try again: https://tbpl.mozilla.org/?tree=Try&rev=46c8c835c22d
Created attachment 634693 [details] [diff] [review]
patch
Attachment #634616 - Attachment is obsolete: true
Attachment #634693 - Flags: review?(bent.mozilla)
Attachment #634693 - Flags: review?(bent.mozilla) → review+
Ah I forgot the -u mercurial flag.

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f0cb242f0e6
https://hg.mozilla.org/mozilla-central/rev/6f0cb242f0e6
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla15 → mozilla16
You need to log in before you can comment on or make changes to this bug.