The default bug view has changed. See this FAQ.

GCLI needs a new home

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Console
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

unspecified
Firefox 15
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 2 obsolete attachments)

Currently GCLI lives in various files in 'webconsole', but this is an articfact of history because it is now used entirely by the developer toolbar in 'shared', and not by anything in 'webconsole'.

I propose a new devtools/gcli directory.

At the same time we should:
- Use devtools/gcli/generated for files from the GCLI project
  I think this directory would contain 3 files (probably) for GCLI modules
  The point of the separation is to make it clearer which files have an
  external source
- Split console.js out so it doesn't have to be duplicated
- Split the module loader out so it doesn't have to be duplicated
  (both of these probably should live in 'shared')
- Split gcli.jsm into:
  - devtools/gcli/gcli.jsm ('public' interface for devtools)
  - devtools/gcli/generated/common-modules.jsm (imported modules, see above)
- Move command-loading from DeveloperToolbar to gcli.jsm
- Work to get as many firefox resources out of gcli and into central
Blocks: 745773
Created attachment 622427 [details] [diff] [review]
Upload 1

Rob - there's a ton of stuff here, I'm happy to talk it through with you - I think that would probably save lots of time.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Attachment #622427 - Flags: review?(rcampbell)
Some additional context for this move:
- I'd like to take any breaking changes for the GCLI API now rather than later
  If moving things around could break commands then we want to do this now.
- The NetPanel import depends on the files we split out here.

Comment 3

5 years ago
Can we call the directory 'commandline' so that people have a chance of finding it without knowing our esoteric name for the command line?
(In reply to Dave Camp (:dcamp) from comment #3)
> Can we call the directory 'commandline' so that people have a chance of
> finding it without knowing our esoteric name for the command line?

sensible.
Created attachment 624166 [details] [diff] [review]
Upload 2

Fixes known issues
Attachment #622427 - Attachment is obsolete: true
Attachment #622427 - Flags: review?(rcampbell)
Attachment #624166 - Flags: review?(rcampbell)
https://tbpl.mozilla.org/?tree=Try&rev=5e93d67dc98d
Blocks: 749397
Comment on attachment 624166 [details] [diff] [review]
Upload 2

per discussion in IRC.
Attachment #624166 - Flags: review?(rcampbell) → review+
Created attachment 624786 [details] [diff] [review]
Upload 3


Fixes Rob's comments from IRC:
- License header was incorrectly standard Firefox header, changed back to reflect
  gcli license.
- Gcli.jsm vs GCLI.jsm: I left it as it originally was gcli.jsm
  I think the lowercase.jsm for imported modules we discussed originally makes
  lots of sense. Lets stick with that.

Also:
https://tbpl.mozilla.org/?tree=Try&rev=247f6c538eb3
Attachment #624166 - Attachment is obsolete: true
https://tbpl.mozilla.org/?tree=Fx-Team&rev=985058b05905
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/985058b05905
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 758819
You need to log in before you can comment on or make changes to this bug.