|
352 bytes,
text/plain
|
Details |
We are missing the Flash version for npswf32_11_2_202_228.dll in our detection, that should be fixed. bp-e8cf70c4-bfd4-4735-a95e-14f272120405 for example shows that DLL, and in "Modules" I see it has a version, but we don't put a Flash version on the report, I guess we might not look for this file name. https://crash-stats.mozilla.com/report/list?signature=npswf32_11_2_202_228.dll%400x421b9e and others are not showing any Flash version because of that. Because of this bug, all my Flash reports are also missing out on crashes from this new version.
|
(Reporter) | |
Comment 1•6 years ago
|
||
Given how much of our analysis looks at Flash versions, this is critical for CrashKill.
|
|
(Reporter) | |
Comment 2•6 years ago
|
||
I created a patch that I hope fixes this: https://github.com/mozilla/socorro/pull/484 The only problem I see is that I'd prefer this to be in production last week :(
|
|
(Reporter) | |
Comment 3•6 years ago
|
||
Created attachment 612583 [details]
Some modules lines from those new versions
Lars asked for some module info for such versions, here they are, taken from a search for crashes containing "npswf32_11_" (as we don't resolve symbols for a couple of those yet anyhow). :)
|
||
Comment 4•6 years ago
|
||
Peter, this change needs review and a test. Please write the test and then land the changes ASAP.
|
(Assignee) | |
Comment 5•6 years ago
|
||
I wrote the tests and corrected the code based on how I think/guessed it should be interpreted. https://github.com/mozilla/socorro/pull/484#issuecomment-5035029
|
||
Comment 7•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/3bfca677ac83f4e9a6b6cb963b976063be495c09 Fixes bug 742735 - Detect new Windows Flash versions that have the version in their file name https://github.com/mozilla/socorro/commit/ba283b1cc15dba06c22c6864e1986a58c574c562 Merge pull request #484 from KaiRo-at/master Bug 742735 - detect new Windows Flash versions correctly
|
|
||
Updated•6 years ago
|
||
|
|
||
Comment 8•6 years ago
|
||
Commit pushed to stage at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/681a80f5e5b3df9312cd9f5ff42ea854aefe5ba4 Fixes bug 742735 - Detect new Windows Flash versions that have the version in their file name
|
|
(Reporter) | |
Updated•6 years ago
|
||
Description
•