The default bug view has changed. See this FAQ.

Turn off the debug mode by default for dom/system/gonk/systemlibs.js

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 612594 [details] [diff] [review]
Patch
Attachment #612594 - Flags: review?(kyle)
Created attachment 612609 [details] [diff] [review]
Patch v0.2

Actually there is a if DEBUG that seems to not make sense too.
Attachment #612594 - Attachment is obsolete: true
Attachment #612594 - Flags: review?(kyle)
Attachment #612609 - Flags: review?
Attachment #612609 - Flags: review? → review?(kyle)
The systemlibs.js DEBUG guards seem dicey. Aren't we only going to be printing those when running from desktop b2g anyways? Wouldn't it be nice to know points where we're having to stub in libraries? Or are these causing print spam?
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #3)
> The systemlibs.js DEBUG guards seem dicey. Aren't we only going to be
> printing those when running from desktop b2g anyways? Wouldn't it be nice to
> know points where we're having to stub in libraries? Or are these causing
> print spam?

Yeah that's only on desktop AFAIK. It's nice to know we have stubs in libraries but this is likely something you want to know when you're debugging an issue in this part of the code, otherwise it sounds just like print spam to me.
Comment on attachment 612609 [details] [diff] [review]
Patch v0.2

Eh, yeah, good point. It should probably be transparent if not on DEBUG mode.
Attachment #612609 - Flags: review?(kyle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b5a0a7c2dbc
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/3b5a0a7c2dbc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This completely broke RIL and Wifi due to the double const. Please always test your patches on the device! I have fix ready, just testing on the device now to make sure.
Component: General → DOM: Device Interfaces
OS: All → Gonk
QA Contact: general → device-interfaces
Hardware: All → ARM
Fixed in https://hg.mozilla.org/mozilla-central/rev/10622eaff4fc
You need to log in before you can comment on or make changes to this bug.