Closed Bug 742780 Opened 8 years ago Closed 8 years ago
Turn off the debug mode by default for dom/system/gonk/systemlibs
No description provided.
Actually there is a if DEBUG that seems to not make sense too.
8 years ago
Attachment #612609 - Flags: review? → review?(kyle)
The systemlibs.js DEBUG guards seem dicey. Aren't we only going to be printing those when running from desktop b2g anyways? Wouldn't it be nice to know points where we're having to stub in libraries? Or are these causing print spam?
(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #3) > The systemlibs.js DEBUG guards seem dicey. Aren't we only going to be > printing those when running from desktop b2g anyways? Wouldn't it be nice to > know points where we're having to stub in libraries? Or are these causing > print spam? Yeah that's only on desktop AFAIK. It's nice to know we have stubs in libraries but this is likely something you want to know when you're debugging an issue in this part of the code, otherwise it sounds just like print spam to me.
Comment on attachment 612609 [details] [diff] [review] Patch v0.2 Eh, yeah, good point. It should probably be transparent if not on DEBUG mode.
Attachment #612609 - Flags: review?(kyle) → review+
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
This completely broke RIL and Wifi due to the double const. Please always test your patches on the device! I have fix ready, just testing on the device now to make sure.
Component: General → DOM: Device Interfaces
OS: All → Gonk
QA Contact: general → device-interfaces
Hardware: All → ARM
You need to log in before you can comment on or make changes to this bug.