742780 - Turn off the debug mode by default for dom/system/gonk/systemlibs.js

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Actually there is a if DEBUG that seems to not make sense too.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

The systemlibs.js DEBUG guards seem dicey. Aren't we only going to be printing those when running from desktop b2g anyways? Wouldn't it be nice to know points where we're having to stub in libraries? Or are these causing print spam?

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #3)
> The systemlibs.js DEBUG guards seem dicey. Aren't we only going to be
> printing those when running from desktop b2g anyways? Wouldn't it be nice to
> know points where we're having to stub in libraries? Or are these causing
> print spam?

Yeah that's only on desktop AFAIK. It's nice to know we have stubs in libraries but this is likely something you want to know when you're debugging an issue in this part of the code, otherwise it sounds just like print spam to me.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 612609 [details] [diff] [review]
Patch v0.2

Eh, yeah, good point. It should probably be transparent if not on DEBUG mode.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b5a0a7c2dbc

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/3b5a0a7c2dbc

Comment 8

[Philipp von Weitershausen [:philikon]]

This completely broke RIL and Wifi due to the double const. Please always test your patches on the device! I have fix ready, just testing on the device now to make sure.

Comment 9

[Philipp von Weitershausen [:philikon]]

Fixed in https://hg.mozilla.org/mozilla-central/rev/10622eaff4fc