742794 - Client should abort if told to start gecko instance on a used host/port

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Right now, if the client is told to start a b2g instance on a used host/port combination, it will kick off the process. It should first detect that this is unused, and if it is free, it should then start the process. Otherwise, it should throw an error

Comment 1

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: check for available port

As discussed on IRC, I've only added the check before starting the Gecko instance.

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 692003 [details] [diff] [review]
check for available port

Review of attachment 692003 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch, I'll r+ once we get the Exception change through.

::: testing/marionette/client/marionette/marionette.py
@@ +119,5 @@
>          if bin:
> +            port = int(self.port)
> +            if not Marionette.is_port_available(port, host=self.host):
> +                print >> sys.stderr, "%s:%d is unavailable." % (self.host, port)
> +                sys.exit(1)

This style on lines 122-123 is a bit odd. Here, I'd throw an Exception instead of print/exit, since it will by default print to stderr and set the exit code to 1, and anyone using the Marionette object can catch that exception if they want.

@@ +171,5 @@
> +            return True
> +        except socket.error:
> +            return False
> +        finally:
> +            s.close()

Ah, helpful!

Comment 3

[Mihnea Dobrescu-Balaur (:mihneadb)]

Attachment: raise MarionetteException when the port is unavailable

There :)

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 692305 [details] [diff] [review]
raise MarionetteException when the port is unavailable

Review of attachment 692305 [details] [diff] [review]:
-----------------------------------------------------------------

yay!

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95d84732129

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95d847321295

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

https://hg.mozilla.org/releases/mozilla-b2g18/pushloghtml?changeset=71f7f42dee13

Comment 8

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/b409fb8b4d25