Note: There are a few cases of duplicates in user autocompletion which are being worked on.

B2G Wifi: Fix wifi shutdown (and restart) on ICS

RESOLVED FIXED

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
There are a couple of bugs making us unable to restart wifi. This is the most important one. I'll file another bug tomorrow on the remaining stuff.
(Assignee)

Comment 1

5 years ago
Created attachment 612610 [details] [diff] [review]
Proposed fix

This patch does the following:
- Sending TERMINATE terminates the supplicant gracefully.
- Calling closeSupplicantConnection would have fixed this bug alone, but in general it resets wifi.c's internal socket state and prevents us from reusing the old sockets when we restart.
- closeSupplicantConnection returns void, not int, so we shouldn't try to get a return value from it.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #612610 - Flags: review?(jones.chris.g)
Does this fix bug 740719?
(Assignee)

Comment 3

5 years ago
As far as I can tell, it doesn't. However it does allow the wifi component to shut down (which is a bug fix that would affect that bug). Note that I've locally removed the error checking on this path. Each function call tries harder to kill the supplicant, so a failure to kill it in one function shouldn't stop us from continuing.
(Assignee)

Updated

5 years ago
Blocks: 740719
Attachment #612610 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/mozilla-central/rev/d25c5f07be7d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.