Closed
Bug 742804
Opened 13 years ago
Closed 13 years ago
Dialog dictates user to attempt to save downloads elsewhere
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(blocking-fennec1.0 -, fennec+)
RESOLVED
FIXED
Firefox 20
People
(Reporter: aaronmt, Assigned: gbrown)
Details
Attachments
(6 files)
See screenshot
There's no user-exposed way to save elsewhere.
--
HTC Nexus One (Android 2.3)
Nightly (04/05)
Reporter | ||
Updated•13 years ago
|
Summary: Dialog dictates user to attempt to save downloads elsewhere (no Micro-SDCard) → Dialog dictates user to attempt to save downloads elsewhere
Comment 1•13 years ago
|
||
Nominating because this is a really ugly interaction and that fixing this requires string changes.
blocking-fennec1.0: --- → ?
Comment 2•13 years ago
|
||
How did you get this situation? No sdcard? Removed the sdcard?
Reporter | ||
Comment 3•13 years ago
|
||
Yes, no SD-Card.
I get a slightly different message today.
Reporter | ||
Comment 4•13 years ago
|
||
"Save as PDF" -> E/GeckoConsole( 1578): [JavaScript Error: "NS_ERROR_FILE_ACCESS_DENIED: Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.createUnique]" {file: "chrome://browser/content/browser.js" line: 689}]
Comment 5•13 years ago
|
||
I wonder why we are not changing the "download folder" location to somewhere that exists
Comment 6•13 years ago
|
||
The two screenshots in here are from very different situations. We should have separate bugs for them.
I don't think we want to save to internal memory if this fails. This is a screenshot of the message stock browser shows me when I attempt to download with the sdcard mounted.
Comment 7•13 years ago
|
||
Do we fetch the location for Downloads from the OS? If so, why is it giving us bogus results? Are we caching the location and then removing the card?
Keywords: qawanted
Comment 8•13 years ago
|
||
There is no "correct" result for where to save downloads in this case, so they can't really give us something bogus. The docs aren't exactly clear:
http://developer.android.com/reference/android/os/Environment.html#getExternalStoragePublicDirectory%28java.lang.String%29
but it sounds like they likely give us the same path regardless of what is currently available and expect us to check before using it. We do check and end up with a write error which sends us here:
http://mxr.mozilla.org/mozilla-central/source/uriloader/exthandler/nsExternalHelperAppService.cpp#1673
but we don't currently have an error message that's well suited to this situation. It seems like a rare edge case situation to me (XUL Fennec also ships with this problem, but doesn't show ANY error because of some non-e10s code in here that depends on having a Window). But we should fix it sometime.
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
Uninstalled nightly
Powered off the device
Removed SD card
Restarted device
Reinstalled nightly
tried to download a file
Updated•13 years ago
|
Attachment #616981 -
Attachment mime type: text/plain → image/png
Comment 11•13 years ago
|
||
I propose we add a sane error message, perhaps in a different part of the code. We don't even what to start a download without an SD card, so the sooner we bail out the better. That said, I don't think this should block.
You're going to get an error either way. We will not open a directory picker and allow you to continue.
Comment 12•13 years ago
|
||
The assumption is that users will not run into this. If we see user reports of this during beta, please renom.
blocking-fennec1.0: ? → -
Comment 13•13 years ago
|
||
Asking for tracking on this as ARMv6 phones are more likely to ship without an sdcard. The HTC Status for example.
tracking-fennec: --- → ?
Updated•13 years ago
|
Assignee: nobody → gbrown
Updated•13 years ago
|
tracking-fennec: ? → 18+
![]() |
Assignee | |
Comment 14•13 years ago
|
||
I checked the current nightly behavior on a Nexus One with SD card physically removed (the SD card cannot be removed from most of my devices). On the Nexus One, I see the message in comment 3: "/mnt/sdcard/<filename> could not be saved, because you cannot change the contents of that folder. Change the folder properties and try again, or try saving in a different location."
The stock browser on my Nexus One reports "No SD card: An SD card is required to download <filename>." -- as shown in Comment 9.
I like the stock browser behavior and message wording.
...but I should clarify the requirement here -- what do we want to do / show here?
Keywords: uiwanted
Comment 16•13 years ago
|
||
I agree with Geoff, the stock browser's dialog as far more appropriate. I would suggest simply using that messaging tbh
Flags: needinfo?(ibarlow)
Comment 17•13 years ago
|
||
This will need strings, should not be tracking a specific release
tracking-fennec: 18+ → +
![]() |
Assignee | |
Comment 18•13 years ago
|
||
This patch simply substitutes the "No SD card" message for the existing one, on Android. It would be nice to first check that the path for the attempted write is on the SD card, and the SD card is not mounted, but I cannot justify that complexity when we always use the SD card.
Good enough?
Attachment #688022 -
Flags: review?(blassey.bugs)
Updated•13 years ago
|
Attachment #688022 -
Flags: review?(blassey.bugs) → review+
![]() |
Assignee | |
Comment 19•13 years ago
|
||
Keywords: uiwanted
Comment 20•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•