Closed
Bug 742805
Opened 13 years ago
Closed 13 years ago
Do not dump ril socket failures on a desktop build with --enable-b2g-ril
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
|
2.59 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
This make sense on the device, but on desktop this is really painful since you don't always have a phone plugged in.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #612613 -
Flags: review?(kyle)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 612613 [details] [diff] [review]
Patch
Review of attachment 612613 [details] [diff] [review]:
-----------------------------------------------------------------
Diverting review to philikon. I agree with the idea, but he's working more with this than I am.
Attachment #612613 -
Flags: review?(kyle) → review?(philipp)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 612613 [details] [diff] [review]
Patch
lgtm. thx!
Attachment #612613 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
|
||
Comment 5•13 years ago
|
||
Sorry, this push was backed out on inbound because one of the changesets caused a leak:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92cc2053db2f
|
|
||
Updated•13 years ago
|
Target Milestone: mozilla14 → ---
|
|
Assignee | |
Comment 6•13 years ago
|
||
Target Milestone: --- → mozilla14
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•