Last Comment Bug 742849 - Disable AvailableMemoryTracker tracker on x86-64
: Disable AvailableMemoryTracker tracker on x86-64
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Justin Lebar (not reading bugmail)
:
Mentors:
Depends on: 742491
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-05 12:34 PDT by Justin Lebar (not reading bugmail)
Modified: 2012-05-03 08:30 PDT (History)
7 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.99 KB, patch)
2012-04-23 08:05 PDT, Justin Lebar (not reading bugmail)
benjamin: review+
Details | Diff | Review

Description Justin Lebar (not reading bugmail) 2012-04-05 12:34:57 PDT
Once bug 742491 lands, we'll have a (hopefully) thread-safe implementation of WindowsDllInterceptor::AddHook for the functions that AvailableMemoryTracker overrides.

But we won't have a similar fix for x86-64.  Until we do, we should just disable the AvailableMemoryTracker there.  It's doing minimal good, anyway.
Comment 1 Mozilla RelEng Bot 2012-04-23 01:47:44 PDT
Try run for 2c455f12a9f2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=2c455f12a9f2
Results (out of 50 total builds):
    success: 43
    warnings: 7
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jlebar@mozilla.com-2c455f12a9f2
Comment 2 Justin Lebar (not reading bugmail) 2012-04-23 08:05:28 PDT
Created attachment 617482 [details] [diff] [review]
Patch v1
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-05-02 21:06:43 PDT
https://hg.mozilla.org/mozilla-central/rev/e7eab0a18edd
Comment 4 Daniel Cater 2012-05-03 04:55:31 PDT
What's the distribution of total RAM like for 32-bit operating systems vs 64-bit operating systems? I assume Telemetry provides the necessary data.

I see quite a few 64-bit machines (with Windows 7 64-bit) sold with 2 GB of RAM. I don't know if that is less than your definition of "fair bit of physical memory".
Comment 5 Justin Lebar (not reading bugmail) 2012-05-03 08:06:33 PDT
This wasn't really a decision based on hardware specs.  I disabled a fringe feature (low-memory detection) in favor of stability.

I have no way to make the code, as it exists, thread-safe on 64-bit.  If we figure it out (it's a fair bit of tricky work, and win64 isn't even tier 1), I'll gladly turn the feature back on.
Comment 6 Justin Lebar (not reading bugmail) 2012-05-03 08:17:45 PDT
For the sake of completeness, I'm looking for our telemetry on physical memory.  I could have sworn we collect it, but I'm not seeing it in the dashboard.
Comment 7 Justin Lebar (not reading bugmail) 2012-05-03 08:30:01 PDT
We do collect physical memory size, but we don't surface it in the telemetry dashboards.  :(

Note You need to log in before you can comment on or make changes to this bug.