Disable AvailableMemoryTracker tracker on x86-64

RESOLVED FIXED in mozilla15

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Justin Lebar (not reading bugmail), Assigned: Justin Lebar (not reading bugmail))

Tracking

unspecified
mozilla15
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Once bug 742491 lands, we'll have a (hopefully) thread-safe implementation of WindowsDllInterceptor::AddHook for the functions that AvailableMemoryTracker overrides.

But we won't have a similar fix for x86-64.  Until we do, we should just disable the AvailableMemoryTracker there.  It's doing minimal good, anyway.
(Assignee)

Updated

5 years ago
OS: Linux → Windows 7
(Assignee)

Updated

5 years ago
Assignee: nobody → justin.lebar+bug

Comment 1

5 years ago
Try run for 2c455f12a9f2 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=2c455f12a9f2
Results (out of 50 total builds):
    success: 43
    warnings: 7
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jlebar@mozilla.com-2c455f12a9f2
(Assignee)

Comment 2

5 years ago
Created attachment 617482 [details] [diff] [review]
Patch v1
Attachment #617482 - Flags: review?(benjamin)
Attachment #617482 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/e7eab0a18edd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15

Comment 4

5 years ago
What's the distribution of total RAM like for 32-bit operating systems vs 64-bit operating systems? I assume Telemetry provides the necessary data.

I see quite a few 64-bit machines (with Windows 7 64-bit) sold with 2 GB of RAM. I don't know if that is less than your definition of "fair bit of physical memory".
(Assignee)

Comment 5

5 years ago
This wasn't really a decision based on hardware specs.  I disabled a fringe feature (low-memory detection) in favor of stability.

I have no way to make the code, as it exists, thread-safe on 64-bit.  If we figure it out (it's a fair bit of tricky work, and win64 isn't even tier 1), I'll gladly turn the feature back on.
(Assignee)

Comment 6

5 years ago
For the sake of completeness, I'm looking for our telemetry on physical memory.  I could have sworn we collect it, but I'm not seeing it in the dashboard.
(Assignee)

Comment 7

5 years ago
We do collect physical memory size, but we don't surface it in the telemetry dashboards.  :(
You need to log in before you can comment on or make changes to this bug.