743049 - Inconsistent error message for uncaught JS exception in Console

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

new xxx -> "xxx is not defined"
throw new ReferenceError("xxx is not defined") -> "ReferenceError: xxx is not defined"

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Part 1: Add a friend API to get an error type name from a number

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Use the new API from NS_ScriptErrorReporter to get a error type name

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 612725 [details] [diff] [review]
Part 2: Use the new API from NS_ScriptErrorReporter to get a error type name

Review of attachment 612725 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsJSEnvironment.cpp
@@ +489,5 @@
>  
>        const PRUnichar *m = reinterpret_cast<const PRUnichar*>
>                                               (report->ucmessage);
>        if (m) {
> +        const PRUnichar *n = reinterpret_cast<const PRUnichar*>

static_cast, and * on the left, please.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Use the new API from NS_ScriptErrorReporter to get a error type name, v2

Fixed failing tests and added a test.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 612724 [details] [diff] [review]
Part 1: Add a friend API to get an error type name from a number

It wasn't immediately clear why JSEXN_INTERNALERR returned null; could you an include a comment explaining why?

Comment 6

[Masatoshi Kimura [:emk]]

I added the check to prevent "InternalError: " is prepended before "uncaught exception: ".
Is it better to test |errorNumber == JSMSG_UNCAUGHT_EXCEPTION|?

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: Bug 743049 -Part 1: Add a friend API to get an error type name from a number

Patch for checkin

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1e86ae73fc5
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dbeef29e1cf

Comment 9

[Richard Newman [:rnewman]]

Backed out whole merge for bustage per Yoric (Bug 743574):

https://hg.mozilla.org/integration/mozilla-inbound/rev/12e42fb8e321

Comment 10

[Richard Newman [:rnewman]]

Disregard that; PEBKAC. Did not get backed out. I misread TBPL.

Comment 11

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/b1e86ae73fc5
https://hg.mozilla.org/mozilla-central/rev/9dbeef29e1cf