Note: There are a few cases of duplicates in user autocompletion which are being worked on.

B2G SMS: error notification for REQUEST_GET_SMSC_ADDRESS failure is not fired

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vicamo, Assigned: vicamo)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Bug 727319 add error notification for REQUEST_GET_SMSC_ADDRESS failure but it will actually never get fired for typo. The lines in REQUEST_GET_SMSC_ADDRESS handler:

  if (options.rilRequestError) {
    if (options.body) {

should be:

  if (options.rilRequestError) {
    if (options.fullBody) {

A better replacement might be checking `options.type == sendSMS` instead.
(Assignee)

Comment 1

5 years ago
Note that bug 740238 tries to remove SMSC pre-fetching related code, and this bug just falls into its target range. Since it's still under review & verification on Akami, fixing this bug is still necessary for now.
(Assignee)

Comment 2

5 years ago
Created attachment 612815 [details] [diff] [review]
check options.type in REQUEST_GET_SMSC_ADDRESS handler
Attachment #612815 - Flags: review?(philipp)
Attachment #612815 - Flags: review?(philipp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/26a56a089f89
https://hg.mozilla.org/mozilla-central/rev/26a56a089f89
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.