Closed
Bug 743179
Opened 13 years ago
Closed 13 years ago
B2G SMS: error notification for REQUEST_GET_SMSC_ADDRESS failure is not fired
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: vicamo, Assigned: vicamo)
References
Details
Attachments
(1 file)
|
1.00 KB,
patch
|
philikon
:
review+
|
Details | Diff | Splinter Review |
Bug 727319 add error notification for REQUEST_GET_SMSC_ADDRESS failure but it will actually never get fired for typo. The lines in REQUEST_GET_SMSC_ADDRESS handler:
if (options.rilRequestError) {
if (options.body) {
should be:
if (options.rilRequestError) {
if (options.fullBody) {
A better replacement might be checking `options.type == sendSMS` instead.
|
Assignee | |
Comment 1•13 years ago
|
||
Note that bug 740238 tries to remove SMSC pre-fetching related code, and this bug just falls into its target range. Since it's still under review & verification on Akami, fixing this bug is still necessary for now.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #612815 -
Flags: review?(philipp)
|
||
Updated•13 years ago
|
Attachment #612815 -
Flags: review?(philipp) → review+
|
|
||
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•