Closed Bug 743190 Opened 12 years ago Closed 11 years ago

GCLI Inputter.onWindowResize has bizarre resize/null element protection. Why?

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect, P3)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: jwalker, Unassigned)

Details

It looks like this (inputter.js)

Inputter.prototype.onWindowResize = function() {
  // Mochitest sometimes causes resize after shutdown
  if (!this.element) {
    return;
  }
  //...
};

Why do we need this? Surely the lifecycle of this.element is strictly longer (at both ends) than the resize listener registration?
Blocks: 745773
No longer blocks: 745773
Target Milestone: Firefox 15 → Firefox 16
Triage, filter on TEABAGS
Target Milestone: Firefox 16 → Future
Hi.. I am new here and would like to work on this bug. Could you please guide me ?
I'm not sure that this bug is a good place to start. I suggest something from https://bugzilla.mozilla.org/buglist.cgi?quicksearch=gcli%20first
New component triage. Filter on "Lobster Thermidor aux crevettes with a Mornay sauce"
Component: Developer Tools: Console → Developer Tools: Graphic Commandline and Toolbar
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.