The default bug view has changed. See this FAQ.

Remove -DOSTYPE and -DOSARCH from config.mk

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The only place I can find where -DOSTYPE is useful (fsvo useful) is:
http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/unix/nsUNIXCharset.cpp#85
And this could use a definition from intl/locale/src/unix/Makefile.in instead of config.mk.

OSARCH is used in:
http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#695
And that could most certainly be replaced by %ifdef XP_OS2.
(Assignee)

Comment 1

5 years ago
Created attachment 612896 [details] [diff] [review]
Remove OSARCH and OSTYPE defines from config.mk
Attachment #612896 - Flags: review?(ted.mielczarek)
Comment on attachment 612896 [details] [diff] [review]
Remove OSARCH and OSTYPE defines from config.mk

Review of attachment 612896 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +665,5 @@
>  -include $(topsrcdir)/$(MOZ_BUILD_APP)/app-config.mk
>  -include $(MY_CONFIG)
>  
>  ######################################################################
>  # Now test variables that might have been set or overridden by $(MY_CONFIG).

Probably just ditch this comment too?
Attachment #612896 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/73faea91726d
Target Milestone: --- → mozilla15
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
https://hg.mozilla.org/mozilla-central/rev/73faea91726d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.