Closed
Bug 743241
Opened 13 years ago
Closed 13 years ago
Remove -DOSTYPE and -DOSARCH from config.mk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The only place I can find where -DOSTYPE is useful (fsvo useful) is:
http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/unix/nsUNIXCharset.cpp#85
And this could use a definition from intl/locale/src/unix/Makefile.in instead of config.mk.
OSARCH is used in:
http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#695
And that could most certainly be replaced by %ifdef XP_OS2.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #612896 -
Flags: review?(ted.mielczarek)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 612896 [details] [diff] [review]
Remove OSARCH and OSTYPE defines from config.mk
Review of attachment 612896 [details] [diff] [review]:
-----------------------------------------------------------------
::: config/config.mk
@@ +665,5 @@
> -include $(topsrcdir)/$(MOZ_BUILD_APP)/app-config.mk
> -include $(MY_CONFIG)
>
> ######################################################################
> # Now test variables that might have been set or overridden by $(MY_CONFIG).
Probably just ditch this comment too?
Attachment #612896 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla15
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → mh+mozilla
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•