Last Comment Bug 743241 - Remove -DOSTYPE and -DOSARCH from config.mk
: Remove -DOSTYPE and -DOSARCH from config.mk
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla15
Assigned To: Mike Hommey [:glandium]
:
: Gregory Szorc [:gps]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-06 08:35 PDT by Mike Hommey [:glandium]
Modified: 2012-04-25 07:46 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove OSARCH and OSTYPE defines from config.mk (3.07 KB, patch)
2012-04-06 08:40 PDT, Mike Hommey [:glandium]
ted: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2012-04-06 08:35:01 PDT
The only place I can find where -DOSTYPE is useful (fsvo useful) is:
http://mxr.mozilla.org/mozilla-central/source/intl/locale/src/unix/nsUNIXCharset.cpp#85
And this could use a definition from intl/locale/src/unix/Makefile.in instead of config.mk.

OSARCH is used in:
http://mxr.mozilla.org/mozilla-central/source/layout/style/forms.css#695
And that could most certainly be replaced by %ifdef XP_OS2.
Comment 1 Mike Hommey [:glandium] 2012-04-06 08:40:04 PDT
Created attachment 612896 [details] [diff] [review]
Remove OSARCH and OSTYPE defines from config.mk
Comment 2 Ted Mielczarek [:ted.mielczarek] 2012-04-06 09:13:54 PDT
Comment on attachment 612896 [details] [diff] [review]
Remove OSARCH and OSTYPE defines from config.mk

Review of attachment 612896 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +665,5 @@
>  -include $(topsrcdir)/$(MOZ_BUILD_APP)/app-config.mk
>  -include $(MY_CONFIG)
>  
>  ######################################################################
>  # Now test variables that might have been set or overridden by $(MY_CONFIG).

Probably just ditch this comment too?

Note You need to log in before you can comment on or make changes to this bug.