Closed
Bug 743250
Opened 13 years ago
Closed 12 years ago
test_xhr_implicit_cancel.html is() calls miss their msg parameter
Categories
(Core :: DOM: Workers, defect)
Core
DOM: Workers
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: sgautherie, Assigned: maxli)
References
()
Details
(Whiteboard: [good first bug][mentor=khuey][lang=js])
Attachments
(1 file, 1 obsolete file)
|
1.15 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
{
27 is(event.target, worker);
33 is(event.target, worker);
}
See bug 734134 as an example.
|
Assignee | |
Comment 1•13 years ago
|
||
Could you please review? Thanks.
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 613120 [details] [diff] [review]
Patch (v1)
Nit: I would prefer "Expected" than "Correct".
Attachment #613120 -
Flags: feedback+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Corrected wording
Attachment #613120 -
Attachment is obsolete: true
Attachment #613120 -
Flags: review?(khuey)
Attachment #613127 -
Flags: review?(khuey)
Attachment #613127 -
Flags: review?(khuey) → review+
|
||
Comment 4•12 years ago
|
||
Max, want to see if this still applies?
|
|
Assignee | |
Comment 5•12 years ago
|
||
Huh. Forgot about this.
Well, the patch still applies cleanly.
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
|
|
||
Comment 7•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•