Last Comment Bug 743264 - Update pdf.js to Version 0.2.536
: Update pdf.js to Version 0.2.536
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: PDF Viewer (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 14
Assigned To: Brendan Dahl [:bdahl]
:
Mentors:
Depends on: 714712
Blocks: 738979
  Show dependency treegraph
 
Reported: 2012-04-06 09:43 PDT by Brendan Dahl [:bdahl]
Modified: 2013-04-24 09:57 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
pdf.js 0.2.536 (735.26 KB, patch)
2012-04-09 09:22 PDT, Brendan Dahl [:bdahl]
dtownsend: review+
Details | Diff | Splinter Review
pdf.js 0.2.536 (735.26 KB, patch)
2012-04-16 13:58 PDT, Brendan Dahl [:bdahl]
no flags Details | Diff | Splinter Review

Description Brendan Dahl [:bdahl] 2012-04-06 09:43:31 PDT
Changes from previous version:
#1369 Remove unreachable logic after error(...) is called.
#1320 CFF Parser and Compiler
#1361 Fixes TrueType cmap re-encoding
#1382 Use [] instead of new Array(...).
#1415 Fix issue #1302
#1418 Checking if it's a true symbolic truetype font
#1406 Use Different Approach to add Event Listener
#1366 Fix string font names.
#1428 Fixing refimages
#1431 Remove scrollTo on unload
#1430 Fix a couple of closure names.
#1413 Metadata Parsing - Setting proper document title
#1377 Add a Progressbar to the loading indicator
#1417 Don't print missing symbols in the font
#1396 Assign the filename to the page title instead of the full URL
#1448 Fix cff regression.
#1457 Fixes to allow compiling with Closure Compiler
#1491 Change support url for moz central add-on.
#1489 Refactor class method names.
#1488 Make Dict handle all the fetching of Refs.
#1484 Removing double-entry for 'space' for standard encodings
#1486 Improving invalid operations syntax recovery (#1466)
#1443 Fix gradients for fill and stroke.
#1494 Convert Unicode strings in the document info
Comment 1 Brendan Dahl [:bdahl] 2012-04-09 09:22:33 PDT
Created attachment 613312 [details] [diff] [review]
pdf.js 0.2.536
Comment 2 Brendan Dahl [:bdahl] 2012-04-09 09:28:45 PDT
Try server run:
https://tbpl.mozilla.org/?tree=Try&rev=09dac0b950f8
Comment 3 Dave Townsend [:mossop] 2012-04-16 11:29:54 PDT
Comment on attachment 613312 [details] [diff] [review]
pdf.js 0.2.536

Review of attachment 613312 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the typo corrections

::: browser/app/profile/extensions/uriloader@pdf.js/components/PdfStreamConverter.js
@@ +152,5 @@
>      var channel = ioService.newChannel(
>                      'resource://pdf.js/web/viewer.html', null, null);
>  
> +    var listener = this.listener;
> +    // Proxy all the requst observer calls, when it gets to onStopRequst

Typos: request and onStopRequest
Comment 4 Brendan Dahl [:bdahl] 2012-04-16 13:58:36 PDT
Created attachment 615456 [details] [diff] [review]
pdf.js 0.2.536

Addressed the above review comments.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-04-16 15:38:01 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a89be8dbecc
Comment 6 Marco Bonardo [::mak] 2012-04-17 07:43:25 PDT
https://hg.mozilla.org/mozilla-central/rev/7a89be8dbecc

Note You need to log in before you can comment on or make changes to this bug.