The default bug view has changed. See this FAQ.

We need to back PDF.js out of FF14 once it's merged to mozilla-aurora on 4/24

VERIFIED FIXED in Firefox 14

Status

()

Firefox
PDF Viewer
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: akeybl, Unassigned)

Tracking

unspecified
Firefox 14
Points:
---

Firefox Tracking Flags

(firefox14+ verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
We need to back PDF.js out of FF14 once it's merged to mozilla-aurora on 4/24. As discussed in the channel meeting, we can't simply disable a preference because the PDF.js XPI always triggers the 'do you want to install this add-on' screen.
(Reporter)

Updated

5 years ago
status-firefox14: --- → affected
tracking-firefox14: --- → +
Would you prefer us to add a flag so the extension is only only built for nightly? That would be what similar to what test-pilot does, but they only build for aurora and beta.
(Reporter)

Comment 2

5 years ago
(In reply to Brendan Dahl from comment #1)
> Would you prefer us to add a flag so the extension is only only built for
> nightly? That would be what similar to what test-pilot does, but they only
> build for aurora and beta.

If that's simple to implement, it seems this would be the lowest touch way of preventing PDF.js from moving up to Aurora. This would be an especially good idea if we're not confident that it'll be ready for the 6/5 uplift either.
The flag makes sense for test pilot as we plan to never ship it in nightly/release builds. In this case I wouldn't overthink it and I'd just remove the bits from the makefile that cause us to package pdf.js.
I guess I just remembered that we also have to added it to removed-filed and remove it from the packaging manifest, so not quite as simple as I thought
Created attachment 618238 [details] [diff] [review]
patch

robstrong reviewed this over my shoulder. It's gone through try as well, just needs approvals.
Attachment #618238 - Flags: review+
Attachment #618238 - Flags: approval-mozilla-aurora?
Attachment #618238 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Landed: https://hg.mozilla.org/releases/mozilla-aurora/rev/50ff48cd1ff3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-firefox14: affected → fixed
Resolution: --- → FIXED
(Reporter)

Comment 7

5 years ago
(In reply to Dave Townsend (:Mossop) from comment #6)
> Landed: https://hg.mozilla.org/releases/mozilla-aurora/rev/50ff48cd1ff3

Thanks for the fast turnaround! :)

Updated

5 years ago
Target Milestone: --- → Firefox 14
(Reporter)

Updated

5 years ago
Blocks: 753533
Verified that PDF Viewer is not available in Firefox 14.0:
Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20100101 Firefox/14.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20100101 Firefox/14.0
Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0
Status: RESOLVED → VERIFIED
status-firefox14: fixed → verified
You need to log in before you can comment on or make changes to this bug.