743306 - Fix MOZ_Assert and MOZ_Crash for Android

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: bug-743306-part-1-MOZ_Assert-logcat.patch

Android's stdio and stderr are directed to /dev/null. On Android, log MOZ_Assert message to adb logcat instead of fprintf(stderr).

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: bug-743306-part-2-MOZ_Crash-segfault.patch

On Android, segfault in MOZ_Crash because raise(SIGABRT) is handled asynchronously.

When MOZ_Crash raises SIGABRT, the process does not die immediately. MOZ_Crash returns and the thread continues running. When all threads in the process receives a SIBABRT, the current thread's call stack will not point to MOZ_Crash. 

If we segfault in MOZ_Crash, we crash immediately and capture the current call stack pointing to MOZ_Crash. Android's dalvikvm and abort() segfault for the same reasons.

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a7965116a33
https://hg.mozilla.org/integration/mozilla-inbound/rev/42870fe1a4a3

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/8a7965116a33
https://hg.mozilla.org/mozilla-central/rev/42870fe1a4a3