743384 - Remove unused E10S abstraction from loader

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

E10S abstraction layer introduces level of complexity for 0 benefit now and for unknown benefit if any in the future. On the other hand it gets into the way of landing loader into firefox, so it should be removed until we'll have a need for it.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/400

Pointer to Github pull-request

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 614428 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/400

Looks good. Before landing it, could you ensure that a simple addon using Widget API isn't leaking when disabled ?
We faced memleaks due to the removed code, I'd like to be sure that we aren't going to face anothers when removing it!!

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Alexandre Poirot (:ochameau) from comment #2)
> Comment on attachment 614428 [details]
> Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/400
> 
> Looks good. Before landing it, could you ensure that a simple addon using
> Widget API isn't leaking when disabled ?
> We faced memleaks due to the removed code, I'd like to be sure that we
> aren't going to face anothers when removing it!!

Looked using about:compartments I see add-on sandboxes being claimed after add-on is disabled so I guess that's it!

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/6db69f20882f2988984e2f128c1946f74fc6739c
Merge pull request #400 from Gozala/bug/no-e10s@743384

fix Bug 743384 - Remove E10S abstraction layer. r=@ochameau