If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove unused E10S abstraction from loader

RESOLVED FIXED

Status

Add-on SDK
General
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: irakli, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

E10S abstraction layer introduces level of complexity for 0 benefit now and for unknown benefit if any in the future. On the other hand it gets into the way of landing loader into firefox, so it should be removed until we'll have a need for it.
Blocks: 743359
Created attachment 614428 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/400

Pointer to Github pull-request
Attachment #614428 - Flags: review?(poirot.alex)
Comment on attachment 614428 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/400

Looks good. Before landing it, could you ensure that a simple addon using Widget API isn't leaking when disabled ?
We faced memleaks due to the removed code, I'd like to be sure that we aren't going to face anothers when removing it!!
Attachment #614428 - Flags: review?(poirot.alex) → review+
(In reply to Alexandre Poirot (:ochameau) from comment #2)
> Comment on attachment 614428 [details]
> Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/400
> 
> Looks good. Before landing it, could you ensure that a simple addon using
> Widget API isn't leaking when disabled ?
> We faced memleaks due to the removed code, I'd like to be sure that we
> aren't going to face anothers when removing it!!

Looked using about:compartments I see add-on sandboxes being claimed after add-on is disabled so I guess that's it!
Priority: -- → P1

Comment 4

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/6db69f20882f2988984e2f128c1946f74fc6739c
Merge pull request #400 from Gozala/bug/no-e10s@743384

fix Bug 743384 - Remove E10S abstraction layer. r=@ochameau

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.