743386 - remove dependency on global!

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

dependency on global! is get's into the way of landing loader to firefox. We should probably make loader configurable so that globals may be passed in or changed at runtime by a party creating it, this would also require configurable
`dump` and probably removal of redcurrant `Iterator`.

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/396

Pointer to Github pull-request

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 613038 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/396

looks fine to me, and also alex reviewed on github too.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/7fa1cd7d09f988bd75f73bb07f5171ee643eb0e2
Merge pull request #396 from Gozala/bug/no-Iterator@743386

fix Bug 743386 - Get rid of non-standard `Iterator` shim and it's uses. r=@ochameau

Comment 4

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/7fa1cd7d09f988bd75f73bb07f5171ee643eb0e2
Merge pull request #396 from Gozala/bug/no-Iterator@743386