Closed
Bug 743386
Opened 13 years ago
Closed 13 years ago
remove dependency on global!
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: irakli, Unassigned)
References
Details
Attachments
(1 file)
dependency on global! is get's into the way of landing loader to firefox. We should probably make loader configurable so that globals may be passed in or changed at runtime by a party creating it, this would also require configurable
`dump` and probably removal of redcurrant `Iterator`.
|
Reporter | |
Comment 1•13 years ago
|
||
Pointer to Github pull-request
|
|
Reporter | |
Updated•13 years ago
|
Attachment #613038 -
Flags: review?(dietrich)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 613038 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/396
looks fine to me, and also alex reviewed on github too.
Attachment #613038 -
Flags: review?(dietrich) → review+
|
||
Comment 3•13 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/7fa1cd7d09f988bd75f73bb07f5171ee643eb0e2
Merge pull request #396 from Gozala/bug/no-Iterator@743386
fix Bug 743386 - Get rid of non-standard `Iterator` shim and it's uses. r=@ochameau
|
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•13 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/7fa1cd7d09f988bd75f73bb07f5171ee643eb0e2
Merge pull request #396 from Gozala/bug/no-Iterator@743386
You need to log in
before you can comment on or make changes to this bug.
Description
•