7434 - change cvs query to list checkins containing a string

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Bonsai, enhancement, P2)

Description

[Chris Yeh]

Terry...

During a meeting today, it came up that it would be incredibly useful to be able
to use CVS Query to be able to list all files inside of a given time period,
whose diffs contain a particular string.

In other words:

Give me a list of checkins over the least week whose diffs contained the word
"Get_Pref".

I was thinking that this might be a little CPU intensive but not hard. What you'd
do would be: generate the list of files over the last week, then spew the diffs
for each revision to a temp file, and then grep the temp file for the string. if
the string exists in the diff, then display that result in the final query list.

A query like this is extremely powerful, since it would allow you to say "hey,
who has checked in changes that rely on my new API, FooDate()?". Or also "give me
all the diffs where NSString() was involved.

I know you are going on sabbatical soon. Is this possible for you to get to?

Comment 1

[Terry Weissman]

The problem here is that it strikes me as a *lot* CPU intensive.  Several of
these running at once could be a real noticable drag on the machine.  It's
scary.

Comment 2

[Chris Yeh]

well, it's only intensive if you allow it beyond a certain query limit, right?
it's not a week that kills you, it's a month.

is the cpu intensive part the query for the raw diff, or the grep on each raw
diff?

Comment 3

[Terry Weissman]

It's not much more CPU intensive than the "show me all these diffs" button.  But
I'm afraid it would be used a lot more.

It's hard to determine up-front how expensive a query might be, and where the
cut-off points should be.

Whine.

Comment 4

[Terry Weissman]

*** Bug 1923 has been marked as a duplicate of this bug. ***

Comment 5

[Terry Weissman]

[e-mail] is the new owner of Bugzilla and Bonsai.  (For details,
see my posting in netscape.public.mozilla.webtools,
news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)

Comment 6

[Tara Hernandez]

Chris, this seems like a really cool feature, but I only want to do this if we
could restrict the file list--terry's concerns about performance are definitely
worth noting

Comment 7

[Chris Yeh]

Oh, the irony of being assigned a bug that I reported a year ago.

I've been mulling this over in my mind, and Terry is correct, this feature would 
completely thrash a system if it was widely used.

Comment 8

[Tara Hernandez]

So, I'm gonna downgrade this to a P3 as a would be nice, but I'm thinking 
something along these lines--what if Bonsai fed this sort of information into a 
LXR-style indexer?  i.e., there would be one more "ALL" value in loginfo, one 
that would pass the diff to some script that would note the token/symbol into 
some record that could managed seperately but referenced from CVS Query.

Token_Table:

INDEX          REFCOUNT          FILELIST
-----          --------          --------
Get_Pref       10                mozilla/xpcom/blah/blah/foo/bar.c,1.84
                                 mozilla/netwerk/blah/blah/bar/foo.c,1.943
                                 ...
Write_Pref     2                 mozilla/xpcom/blah/blah/foo/ick.c,1.57

Or something.

Comment 9

[selmer (gone)]

Would it be possible to get the CVS Blame for the occurances in another column?
That's the main piece of info that Tina needs from this.  It would be really
cool if the name of the pref could be sucked out of the code, but that's
probably hard.  Maybe just showing the line of code would do it?  (Most of the
time anyway.)

Comment 10

[Chris Yeh]

Wait a second, there are two enhancement requests rattling around in here now:

1) The ability to query bonsai for all changes involving lines that contain a 
given string.

2) Possibly adding cvsblame funcitonality to LXR.

I can't remember off the top of my head, but cvsblame makes calls to RCS to get 
the cvsblame info for a particular file. Doing this over several files might get 
intensive.

I am wondering if there would be a good way of throttling the requests.

Comment 11

[Adam Muntner [:adamm] (use NEEDINFO)]

Bonsai was decommissioned, closing all remaining bugs "wontfix"