Crash [@ nsGlobalWindow::OpenInternal] with preventDefault in DOMWillOpenModalDialog

RESOLVED FIXED in mozilla14

Status

()

--
critical
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jruderman, Assigned: smaug)

Tracking

(Blocks: 1 bug, {crash, testcase})

Trunk
mozilla14
x86_64
macOS
crash, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(crash signature)

Attachments

(4 attachments)

(Reporter)

Description

7 years ago
Created attachment 613057 [details]
testcase
(Reporter)

Comment 1

7 years ago
Created attachment 613058 [details]
stack trace
Assignee: nobody → bugs
Created attachment 614297 [details] [diff] [review]
patch

DOMWillOpenModalDialog should be chrome only event, but let's make that change
in a followup.
Attachment #614297 - Flags: review?(jst)

Updated

7 years ago
Crash Signature: [@ nsGlobalWindow::OpenInternal]
Attachment #614297 - Flags: review?(jst) → review+
Oops, I missed another null check later in the method.
Created attachment 614490 [details] [diff] [review]
even simpler
Attachment #614490 - Flags: review?(jst)
Attachment #614490 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/364f0a5a1d2d
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.