Last Comment Bug 743416 - Crash [@ nsGlobalWindow::OpenInternal] with preventDefault in DOMWillOpenModalDialog
: Crash [@ nsGlobalWindow::OpenInternal] with preventDefault in DOMWillOpenModa...
Status: RESOLVED FIXED
: crash, testcase
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- critical (vote)
: mozilla14
Assigned To: Olli Pettay [:smaug]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 325861
  Show dependency treegraph
 
Reported: 2012-04-06 19:21 PDT by Jesse Ruderman
Modified: 2012-04-14 03:12 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (267 bytes, text/html)
2012-04-06 19:21 PDT, Jesse Ruderman
no flags Details
stack trace (10.31 KB, text/plain)
2012-04-06 19:21 PDT, Jesse Ruderman
no flags Details
patch (881 bytes, patch)
2012-04-12 01:25 PDT, Olli Pettay [:smaug]
jst: review+
Details | Diff | Splinter Review
even simpler (678 bytes, patch)
2012-04-12 12:24 PDT, Olli Pettay [:smaug]
jst: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2012-04-06 19:21:09 PDT
Created attachment 613057 [details]
testcase
Comment 1 Jesse Ruderman 2012-04-06 19:21:26 PDT
Created attachment 613058 [details]
stack trace
Comment 2 Olli Pettay [:smaug] 2012-04-12 01:25:18 PDT
Created attachment 614297 [details] [diff] [review]
patch

DOMWillOpenModalDialog should be chrome only event, but let's make that change
in a followup.
Comment 3 Olli Pettay [:smaug] 2012-04-12 11:16:08 PDT
Oops, I missed another null check later in the method.
Comment 4 Olli Pettay [:smaug] 2012-04-12 12:24:01 PDT
Created attachment 614490 [details] [diff] [review]
even simpler
Comment 5 Olli Pettay [:smaug] 2012-04-14 01:09:12 PDT
https://hg.mozilla.org/mozilla-central/rev/364f0a5a1d2d

Note You need to log in before you can comment on or make changes to this bug.