Closed Bug 743416 Opened 8 years ago Closed 8 years ago

Crash [@ nsGlobalWindow::OpenInternal] with preventDefault in DOMWillOpenModalDialog

Categories

(Core :: DOM: Core & HTML, defect, critical)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jruderman, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: crash, testcase)

Crash Data

Attachments

(4 files)

Attached file testcase
No description provided.
Attached file stack trace
Assignee: nobody → bugs
Attached patch patchSplinter Review
DOMWillOpenModalDialog should be chrome only event, but let's make that change
in a followup.
Attachment #614297 - Flags: review?(jst)
Crash Signature: [@ nsGlobalWindow::OpenInternal]
Attachment #614297 - Flags: review?(jst) → review+
Oops, I missed another null check later in the method.
Attached patch even simplerSplinter Review
Attachment #614490 - Flags: review?(jst)
Attachment #614490 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/364f0a5a1d2d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.