743436 - remove XPCJSRuntime::mJSCycleCollectionContext and related code

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Igor Bukanov]

With the bugs 737364, 723286 the xpconnect implementation no longer needs a JSContext instance to run the cycle collection and XPCJSRuntime::mJSCycleCollectionContext becomes unnecessary and should be removed.

Comment 1

[Igor Bukanov]

Attachment: v1

The patch removes no longer used XPCJSRuntime::mJSCycleCollectionContext,
nsXPConnect::mCycleCollectionContext and related code to create/destroy
contexts. As that made nsCycleCollectionLanguageRuntime::FinishTraverse()
empty in all cases I removed that method as well. In couple of places I
also fixed rotten DEBUG_CC code to adjust that for recent JS API changes.

Comment 2

[Andrew McCreight [:mccr8]]

Nice cleanup!   Could you also remove the line
timeLog.Checkpoint("mRuntimes[*]->FinishTraverse()");
from nsCycleCollector::BeginCollection, as there's no finish traverse to time any more.

Comment 3

[Andrew McCreight [:mccr8]]

Any particular reason this never landed, Igor?  I've unbitrotted this patch and I'll go ahead and land it assuming it passes a try run.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: unbitrotted

Carrying forward peterv's review.

https://tbpl.mozilla.org/?tree=Try&rev=30903f420b15

Comment 5

[Andrew McCreight [:mccr8]]

My try push failed because of some kind of warnings-as-errors thing in editor, so that's awesome...

Comment 6

[Igor Bukanov]

(In reply to Andrew McCreight [:mccr8] from comment #3)
> Any particular reason this never landed, Igor?  

I missed peterv review

Comment 7

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1d5475ec3831

Comment 8

[Paul Wright]

Did Igor leave Mozilla?  I have not seen him on any bugs in a long time, but I don't follow everything.

Comment 9

[Igor Bukanov]

(In reply to Paul Wright from comment #8)
> Did Igor leave Mozilla?  

Yes, a year ago.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d5475ec3831