[Azure] Asseration failed: (mCg) [@mozilla::gfx::DrawTargetCG::Init]

RESOLVED FIXED in Firefox 13

Status

()

Core
Canvas: 2D
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: posidron, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug, {crash, testcase})

Trunk
mozilla14
x86_64
Mac OS X
crash, testcase
Points:
---

Firefox Tracking Flags

(firefox12- wontfix, firefox13+ verified, firefox-esr10-)

Details

(Whiteboard: [qa+], crash signature)

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 613161 [details]
testcase

In: /gfx/2d/DrawTargetCG.cpp:914

[...]
  mCg = CGBitmapContextCreate (mData,
                               mSize.width,
                               mSize.height,
                               bitsPerComponent,
                               stride,
                               mColorSpace,
                               bitinfo);
                   
 
  assert(mCg);
[...]
(Reporter)

Comment 1

5 years ago
Created attachment 613162 [details]
callstack
(Assignee)

Comment 2

5 years ago
I have no idea how common this is. See bug 745818 for tracking whether we want to turn off CoreGraphics for 12.
status-firefox12: --- → affected
status-firefox13: --- → affected
status-firefox14: --- → affected
tracking-firefox-esr10: --- → ?
tracking-firefox12: --- → ?
tracking-firefox13: --- → +
(Assignee)

Comment 3

5 years ago
Created attachment 615488 [details] [diff] [review]
Handle negative sizes

I didn't realize Sizes could be negative when originally writing this code.
Attachment #615488 - Flags: review?(bas.schouten)
Attachment #615488 - Flags: review?(bas.schouten) → review+

Comment 4

5 years ago
Given https://bugzilla.mozilla.org/show_bug.cgi?id=745818#c10, we won't track for FF12.
status-firefox12: affected → wontfix
tracking-firefox12: ? → -

Comment 5

5 years ago
And we'll wait for enterprises to let us know this is a major pain point before fixing on the ESR.
tracking-firefox-esr10: ? → -

Updated

5 years ago
Crash Signature: [@mozilla::gfx::DrawTargetCG::Init]
(Assignee)

Comment 6

5 years ago
Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Approval Request Comment]
Regression caused by (bug #): 692879
User impact if declined: Occasional crashes
Testing completed (on m-c, etc.): test case attached to bug no longer asserts
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Attachment #615488 - Flags: approval-mozilla-central?
Attachment #615488 - Flags: approval-mozilla-aurora?

Comment 7

5 years ago
Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Triage Comment]
Very low risk, approved for mozilla-central.
Attachment #615488 - Flags: approval-mozilla-central? → approval-mozilla-central+
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec09ab2b6e14
Assignee: nobody → jmuizelaar
Target Milestone: --- → mozilla14

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ec09ab2b6e14
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
status-firefox14: affected → ---
Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Triage comment]
Please go ahead and land on Aurora.
Attachment #615488 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Triage Comment]
Sorry, this is meant for Beta, since it was after the merge.
Attachment #615488 - Flags: approval-mozilla-aurora+ → approval-mozilla-beta+
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/c059029404f8
status-firefox13: affected → fixed
Whiteboard: [qa+]

Comment 13

5 years ago
I've verified this on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120517 Firefox/13.0 beta debug build

There is no assertion in the console and the build did not crashed.

Setting the flag to verified.
status-firefox13: fixed → verified
You need to log in before you can comment on or make changes to this bug.