743499 - [Azure] Asseration failed: (mCg) [@mozilla::gfx::DrawTargetCG::Init]

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Christoph Diehl [:posidron]]

Attachment: testcase

In: /gfx/2d/DrawTargetCG.cpp:914

[...]
  mCg = CGBitmapContextCreate (mData,
                               mSize.width,
                               mSize.height,
                               bitsPerComponent,
                               stride,
                               mColorSpace,
                               bitinfo);
                   
 
  assert(mCg);
[...]

Comment 1

[Christoph Diehl [:posidron]]

Attachment: callstack

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I have no idea how common this is. See bug 745818 for tracking whether we want to turn off CoreGraphics for 12.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Handle negative sizes

I didn't realize Sizes could be negative when originally writing this code.

Comment 4

[Alex Keybl [:akeybl]]

Given https://bugzilla.mozilla.org/show_bug.cgi?id=745818#c10, we won't track for FF12.

Comment 5

[Alex Keybl [:akeybl]]

And we'll wait for enterprises to let us know this is a major pain point before fixing on the ESR.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Approval Request Comment]
Regression caused by (bug #): 692879
User impact if declined: Occasional crashes
Testing completed (on m-c, etc.): test case attached to bug no longer asserts
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Triage Comment]
Very low risk, approved for mozilla-central.

Comment 8

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec09ab2b6e14

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec09ab2b6e14

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Triage comment]
Please go ahead and land on Aurora.

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 615488 [details] [diff] [review]
Handle negative sizes

[Triage Comment]
Sorry, this is meant for Beta, since it was after the merge.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c059029404f8

Comment 13

[Vlad [QA]]

I've verified this on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120517 Firefox/13.0 beta debug build

There is no assertion in the console and the build did not crashed.

Setting the flag to verified.