Console should display line number for warning messages

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

Trunk
mozilla14
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 613192 [details] [diff] [review]
Try to get line number if at all possible
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #613192 - Flags: review?(jonas)
(Assignee)

Comment 2

5 years ago
Created attachment 613203 [details] [diff] [review]
Try to get line number if at all possible, v2

Fixed a test failure.
Although the line number is not correct, it is an existing bug. For example,
---
<!DOCTYPE html>
<meta charset=windows-1252>
<title>Non-UTF form</title>
<body onload="throw new Error()">
---
Also reports the line number is 1.
Attachment #613192 - Attachment is obsolete: true
Attachment #613192 - Flags: review?(jonas)
Attachment #613203 - Flags: review?(jonas)
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=3a975e00d93d
Comment on attachment 613203 [details] [diff] [review]
Try to get line number if at all possible, v2

I'm not a good person to review this. Maybe Blake?
Attachment #613203 - Flags: review?(jonas) → review?(mrbkap)
Comment on attachment 613203 [details] [diff] [review]
Try to get line number if at all possible, v2

I think this is right. I'm a little worried that we call ReportToConsole with a URI that's unrelated to the caller, but I couldn't find any examples of that in the tree. r=mrbkap
Attachment #613203 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/11cf97fceacd
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/11cf97fceacd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.