Closed
Bug 743575
Opened 13 years ago
Closed 13 years ago
Console should display line number for warning messages
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: emk, Assigned: emk)
Details
Attachments
(1 file, 1 obsolete file)
|
2.67 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Fixed a test failure.
Although the line number is not correct, it is an existing bug. For example,
---
<!DOCTYPE html>
<meta charset=windows-1252>
<title>Non-UTF form</title>
<body onload="throw new Error()">
---
Also reports the line number is 1.
Attachment #613192 -
Attachment is obsolete: true
Attachment #613192 -
Flags: review?(jonas)
Attachment #613203 -
Flags: review?(jonas)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 613203 [details] [diff] [review]
Try to get line number if at all possible, v2
I'm not a good person to review this. Maybe Blake?
Attachment #613203 -
Flags: review?(jonas) → review?(mrbkap)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 613203 [details] [diff] [review]
Try to get line number if at all possible, v2
I think this is right. I'm a little worried that we call ReportToConsole with a URI that's unrelated to the caller, but I couldn't find any examples of that in the tree. r=mrbkap
Attachment #613203 -
Flags: review?(mrbkap) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•