Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[Azure] League Of Legends website has big black bars on either side

RESOLVED FIXED in mozilla15

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Leman Bennett [Omega], Assigned: bas)

Tracking

14 Branch
mozilla15
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Rendering and then scrolling the League Of Legends website to the very top will result in generating big black bars on either side of the page.

1. Turn on Azure-Thebes Wrapper
2. Load the url
3. Scroll Down
4. Scroll back to the top.

Observe the black patches.

Also, they go away if you shift the focus back and forth to Nightly.
(Reporter)

Comment 1

5 years ago
Created attachment 613202 [details]
Screenshot

Screenshot of the issue.
(Reporter)

Comment 2

5 years ago
Here's another example: http://mozillamemes.tumblr.com/

Scroll the page and notice that the background turns black behind the columns.
(Assignee)

Updated

5 years ago
Blocks: 715768
(Assignee)

Comment 3

5 years ago
I suspect this might be one of the component alpha bugs I introduced (and landed fixes for today on m-i). Try seeing if it's gone in tomorrow's nightly (if the patches make it to m-c in time).
(Reporter)

Comment 4

5 years ago
Using an hourly cset: 576a14e57ea6, The issue remains.

Comment 5

5 years ago
Confirmed with gfx.content.azure.enabled=true in
http://hg.mozilla.org/mozilla-central/rev/576a14e57ea6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120412 Firefox/14.0a1 ID:20120412160832

Regression pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c95b597b5f08&tochange=9fa58c6060c5
Status: UNCONFIRMED → NEW
Ever confirmed: true

Updated

5 years ago
Blocks: 740815
Version: unspecified → 14 Branch

Comment 6

5 years ago
Last good : e36fabc31211
First bad : 9fa58c6060c5
(Assignee)

Comment 7

5 years ago
I believe some of our component alpha fixes may have fixed this. I can no longer reproduce this on inbound, can anyone else?
(Assignee)

Comment 8

5 years ago
(In reply to Leman Bennett (Omega X) from comment #2)
> Here's another example: http://mozillamemes.tumblr.com/
> 
> Scroll the page and notice that the background turns black behind the
> columns.

Hrm, I do see an artifact here but only when I scroll down all the way on the last meme.. I really would like a minimized testcase, I have no idea what's going on :(

Comment 9

5 years ago
Created attachment 616113 [details]
semi reduced html

Comment 10

5 years ago
Created attachment 616122 [details]
semi reduced html
Attachment #616113 - Attachment is obsolete: true

Comment 11

5 years ago
Created attachment 616403 [details]
another sample html
(Assignee)

Comment 12

5 years ago
(In reply to Alice0775 White from comment #11)
> Created attachment 616403 [details]
> another sample html

This is an excellent stand-alone testcase. Hopefully this will let me solve the issue.
Assignee: nobody → bas.schouten
Status: NEW → ASSIGNED
(Assignee)

Comment 13

5 years ago
Created attachment 616705 [details] [diff] [review]
Properly mark ThebesLayer content invalid when changing content type.

When a ThebesLayer changes the content type of the primary surface, we need to mark the content of our surface invalid.

While in this code I noticed right now we create a redundant DrawTarget here that will later be overwritten. This isn't a big issue but it is a waste, so I should fix it at some point. I'll file a bug for this.
Attachment #616705 - Flags: review?(jmuizelaar)
Comment on attachment 616705 [details] [diff] [review]
Properly mark ThebesLayer content invalid when changing content type.

Are we likely to forget anymore of these?
Attachment #616705 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 15

5 years ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #14)
> Comment on attachment 616705 [details] [diff] [review]
> Properly mark ThebesLayer content invalid when changing content type.
> 
> Are we likely to forget anymore of these?

Not likely I don't think, I tried to re-check all of them. But you never know.
https://hg.mozilla.org/mozilla-central/rev/f1132feeb481
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15

Comment 17

5 years ago
Bas

It's possible this patch also fixed bug https://bugzilla.mozilla.org/show_bug.cgi?id=700088 which after updating to cset http://hg.mozilla.org/mozilla-central/rev/cc5254f9825f now works fine.

Do you think so?
(Assignee)

Updated

5 years ago
No longer blocks: 715768
(Assignee)

Updated

5 years ago
Blocks: 715768
You need to log in before you can comment on or make changes to this bug.