Last Comment Bug 743603 - B2G Wifi: minor code readability improvement
: B2G Wifi: minor code readability improvement
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
Depends on:
Blocks: b2g-wifi
  Show dependency treegraph
 
Reported: 2012-04-08 19:24 PDT by Philipp von Weitershausen [:philikon]
Modified: 2012-04-09 00:23 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (8.11 KB, patch)
2012-04-08 19:24 PDT, Philipp von Weitershausen [:philikon]
mrbkap: review+
Details | Diff | Splinter Review
v1.1 (7.50 KB, patch)
2012-04-08 23:55 PDT, Philipp von Weitershausen [:philikon]
no flags Details | Diff | Splinter Review

Description Philipp von Weitershausen [:philikon] 2012-04-08 19:24:25 PDT
Created attachment 613215 [details] [diff] [review]
v1

New license header (<3) and converting big else-if canon to a switch statement.
Comment 1 Blake Kaplan (:mrbkap) 2012-04-08 19:29:43 PDT
Comment on attachment 613215 [details] [diff] [review]
v1

Please leave the emacs and vim modelines in. r=mrbkap with that.
Comment 2 Philipp von Weitershausen [:philikon] 2012-04-08 20:07:57 PDT
(In reply to Blake Kaplan (:mrbkap) from comment #1)
> Please leave the emacs and vim modelines in. r=mrbkap with that.

*mumbles something about people not being able to configure their editors... I for one don't want a Java mode when editing JS filed... mumble mumble* :)

Thanks!
Comment 3 Philipp von Weitershausen [:philikon] 2012-04-08 23:55:02 PDT
Created attachment 613239 [details] [diff] [review]
v1.1

Addressed nit.
Comment 4 Blake Kaplan (:mrbkap) 2012-04-09 00:23:24 PDT
http://hg.mozilla.org/mozilla-central/rev/22521568cf79

Note You need to log in before you can comment on or make changes to this bug.