Closed
Bug 743631
Opened 13 years ago
Closed 13 years ago
Check keycodes instead of scancodes when detecting keyevents
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file)
|
5.35 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
The use of scancodes instead of keycodes was an old hack that has come back to bite me with devices that don't use normal linux scancodes.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #630744 -
Flags: review?(jones.chris.g)
Comment on attachment 630744 [details] [diff] [review]
Use keyCode instead of scanCode and use a lookup table
>diff --git a/widget/gonk/GonkKeyMapping.h b/widget/gonk/GonkKeyMapping.h
>+#ifndef GONKKEYMAPPING_H
>+#define GONKKEYMAPPING_H
>+
Needs a license header.
>+/* See libui/KeycodeLabels.h for the mapping */
>+static const unsigned long kKeyMapping[] = {
I didn't review all of these individually.
r=me with license header.
Attachment #630744 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•