Last Comment Bug 743631 - Check keycodes instead of scancodes when detecting keyevents
: Check keycodes instead of scancodes when detecting keyevents
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget (show other bugs)
: unspecified
: All Gonk (Firefox OS)
: -- normal (vote)
: mozilla16
Assigned To: Michael Wu [:mwu]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-09 02:47 PDT by Michael Wu [:mwu]
Modified: 2012-06-08 13:58 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use keyCode instead of scanCode and use a lookup table (5.35 KB, patch)
2012-06-06 15:42 PDT, Michael Wu [:mwu]
cjones.bugs: review+
Details | Diff | Review

Description Michael Wu [:mwu] 2012-04-09 02:47:51 PDT
The use of scancodes instead of keycodes was an old hack that has come back to bite me with devices that don't use normal linux scancodes.
Comment 1 Michael Wu [:mwu] 2012-06-06 15:42:42 PDT
Created attachment 630744 [details] [diff] [review]
Use keyCode instead of scanCode and use a lookup table
Comment 2 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-06-07 01:40:58 PDT
Comment on attachment 630744 [details] [diff] [review]
Use keyCode instead of scanCode and use a lookup table

>diff --git a/widget/gonk/GonkKeyMapping.h b/widget/gonk/GonkKeyMapping.h

>+#ifndef GONKKEYMAPPING_H
>+#define GONKKEYMAPPING_H
>+

Needs a license header.

>+/* See libui/KeycodeLabels.h for the mapping */
>+static const unsigned long kKeyMapping[] = {

I didn't review all of these individually.

r=me with license header.
Comment 4 Ed Morley [:emorley] 2012-06-08 13:58:03 PDT
https://hg.mozilla.org/mozilla-central/rev/d04694a80016

Note You need to log in before you can comment on or make changes to this bug.