743635 - B2G SMS database initialization accesses Directory Provider off the main thread

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Philipp von Weitershausen [:philikon]]

On Gonk ICS we're seeing an interesting race condition in the emulator: the B2G SMS database service is initialized at startup and immediately initializes an IndexedDB instance. IndexedDB happens to query the Directory Service for ProfD *off the main thread*. This usually works out fine so long as the Directory Service's cache has been primed (e.g. something has already queried for ProfD). In this case, however, we're seeing that the IndexedDB thread is racing the main thread and fails to look up ProfD.

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Comment 2

[Michael Wu [:mwu]]

E/GeckoConsole(  108): Attempt to use JS function on a different thread calling nsIDirectoryServiceProvider.getFile. JS objects may not be shared across threads

Comment 3

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c1ede9f0319e

Comment 4

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/c1ede9f0319e

Comment 5

[(no longer active)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/a235528adace

Comment 6

[Philipp von Weitershausen [:philikon]]

Attachment: v2

Now with the proper Services.jsm import. The missing import was preventing the SmsDatabaseService from initializing the database, so it kind of fixed the freezing problem, but not in a very useful way.

mwu, would you mind testing this new patch with the missing import added, to see if it still fixes the problem?

Comment 7

[Philipp von Weitershausen [:philikon]]

Turns out, the provided patch doesn't fix the freeze, but it *does* fix the off-thread error. So I'm morphing this bug to just deal with that and filed the cloned bug 744300 to deal with the freeze.

Comment 8

[Philipp von Weitershausen [:philikon]]

Comment on attachment 613832 [details] [diff] [review]
v2

(Canceling feedback request, got feedback from mwu over IRC. Will commit this patch as it already has r+.)

Comment 9

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/47577c0fd029

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/47577c0fd029