Last Comment Bug 743640 - IonMonkey: inlineNativeCall should use different return values for errors/aborts
: IonMonkey: inlineNativeCall should use different return values for errors/aborts
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks: IonMonkey
  Show dependency treegraph
 
Reported: 2012-04-09 04:34 PDT by Jan de Mooij [:jandem]
Modified: 2012-05-10 13:46 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch. (11.70 KB, patch)
2012-05-09 15:32 PDT, Sean Stangl [:sstangl]
jdemooij: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] 2012-04-09 04:34:41 PDT
Atm a false return value means either "we decided not to inline" or "there was an error". These cases should use different return values so that we can correctly propagate errors.
Comment 1 Sean Stangl [:sstangl] 2012-05-09 15:32:06 PDT
Created attachment 622543 [details] [diff] [review]
Patch.
Comment 2 Jan de Mooij [:jandem] 2012-05-10 01:30:28 PDT
Comment on attachment 622543 [details] [diff] [review]
Patch.

Review of attachment 622543 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Comment 3 Sean Stangl [:sstangl] 2012-05-10 13:46:25 PDT
https://hg.mozilla.org/projects/ionmonkey/rev/c68a877d643e

Note You need to log in before you can comment on or make changes to this bug.