IonMonkey: inlineNativeCall should use different return values for errors/aborts

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Atm a false return value means either "we decided not to inline" or "there was an error". These cases should use different return values so that we can correctly propagate errors.
Created attachment 622543 [details] [diff] [review]
Patch.
Attachment #622543 - Flags: review?(jdemooij)
(Reporter)

Comment 2

5 years ago
Comment on attachment 622543 [details] [diff] [review]
Patch.

Review of attachment 622543 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #622543 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/c68a877d643e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.