Closed Bug 743640 Opened 12 years ago Closed 12 years ago

IonMonkey: inlineNativeCall should use different return values for errors/aborts

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Atm a false return value means either "we decided not to inline" or "there was an error". These cases should use different return values so that we can correctly propagate errors.
Attached patch Patch.Splinter Review
Attachment #622543 - Flags: review?(jdemooij)
Comment on attachment 622543 [details] [diff] [review]
Patch.

Review of attachment 622543 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #622543 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/c68a877d643e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.