Closed
Bug 743640
Opened 13 years ago
Closed 13 years ago
IonMonkey: inlineNativeCall should use different return values for errors/aborts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
11.70 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Atm a false return value means either "we decided not to inline" or "there was an error". These cases should use different return values so that we can correctly propagate errors.
|
||
Comment 1•13 years ago
|
||
Attachment #622543 -
Flags: review?(jdemooij)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 622543 [details] [diff] [review]
Patch.
Review of attachment 622543 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #622543 -
Flags: review?(jdemooij) → review+
|
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•