743662 - Session is not restored when Firefox is restarted by an addon install/uninstall

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: restart logs

Fennec/14.0a1 2012-04-09
Device: Motorola Droid 2(Android 2.3)

Steps to reproduce:
1. Open Nightly and open a few tabs to different websites.
2. Open the Mobile Addons page.
3. Search for an addon that requires restart with the install/uninstall process.
4. Install it and restart when asked.

Expected results:
Because there was no crash the session is automatically restored.

Actual results:
The session is not restored and the user has to reopen manually all the tabs from the previous session.

Notes: 
This issue is reproducible both when installing and uninstalling addons that require restart.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Reproduced on the current nightly - For an example of an extension that needs restart use https://addons.mozilla.org/en-US/android/addon/copy-as-plain-text/

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We don't restore full tabs in many situations on mobile. The list of tabs should be available on the about:home page.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

I updated nightly today with 4 tabs open and I lost them all.  Doing this on desktop I get all my tabs back.  The problem I had was the list of pages was off the screen below the 6 page thumbnails and the firefox sync.  I didn't realize I could scroll down to see more fun stuff.

this is on a samsung galaxy s3

Comment 4

[Adrian Tamas (:AdrianT)]

Still an issue on Firefox Mobile 21.0b6 and Nightly 23.0a1 2013-05-01 using the Samsung Galaxy Tab 2 (Android 4.1)

Comment 5

[Jan Henning [:JanH]]

There probably aren't that many add-ons requiring a restart left and we restore tabs by default now, but in any case this should be quite easy to fix.

Comment 6

[Jan Henning [:JanH]]

Attachment: Bug 743662 - Restore session once when addons require a restart.

Review commit: https://reviewboard.mozilla.org/r/117128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117128/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8843373 [details]
Bug 743662 - Restore session once when addons require a restart.

https://reviewboard.mozilla.org/r/117128/#review119198

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/010f66117cc5
Restore session once when addons require a restart. r=sebastian

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/010f66117cc5

Comment 10

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 55.0a1 (2017-04-21).
Devices:
-Prestigio Grace X5 (Android 4.4.2)
-LG G4 (Android 5.1)