Closed Bug 743720 Opened 8 years ago Closed 8 years ago

Import Speex's audio resampler in the tree

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(1 file, 5 obsolete files)

We need to import the Speex audio resampler bits in the tree, for the |playbackRate| member of the audio and video elements, and the Media Graph API.
Blocks: 495040
Component: Video/Audio → Web Services
QA Contact: video.audio → web-services
Assignee: nobody → paul
Assignee: paul → nobody
Component: Web Services → Video/Audio
QA Contact: web-services → video.audio
Maybe I should find a build peer to review that as well ?
Assignee: nobody → paul
Status: NEW → ASSIGNED
Attachment #614912 - Flags: review?(kinetik)
Comment on attachment 614912 [details] [diff] [review]
Import the resampler bits of the Speex codec in the tree

Looks good to me, but this does need a build peer to review it as well.

Please add a README_MOZILLA to media/libspeex_resampler that describes the provenance of the code and the version number (or changeset ID) the current import is at.

This code is under a BSD style license, so it'll be fine to import, but I think all imports of third party code need to be run past licensing@mozilla.org (http://www.mozilla.org/MPL/license-policy.html#Licensing_of_Third_Party_Code) and add an attribution blurb to about:license.
Attachment #614912 - Flags: review?(kinetik) → review+
Comment on attachment 614912 [details] [diff] [review]
Import the resampler bits of the Speex codec in the tree

Ted, I need a review from the Build module owner (or a peer) for this patch to land. I've also sent an email to licensing@mozilla.org, and I am waiting for their answer.
Attachment #614912 - Flags: review?(ted.mielczarek)
I've updated the code and added the original AUTHORS and COPYING files. Also added a README_MOZILLA file containing the revision and added a line in about:license.
Attachment #614912 - Attachment is obsolete: true
Attachment #614912 - Flags: review?(ted.mielczarek)
Attachment #617567 - Flags: review?(khuey)
Comment on attachment 617567 [details] [diff] [review]
Updated with AUTHORS and about:license bits

Review of attachment 617567 [details] [diff] [review]:
-----------------------------------------------------------------

Why do we need separate include and src directories here?

::: media/libspeex_resampler/Makefile.in
@@ +45,5 @@
> +
> +DIRS		= \
> +		include \
> +		src \
> +		$(NULL)

Please don't use tabs here.  Tabs are only necessary in rules.

::: media/libspeex_resampler/REAME_MOZILLA
@@ +2,5 @@
> +commit a6d05eb5.
> +
> +It consists in the audio resampling code (resampler.c) and its header files
> +dependancies. No changes have been made to those files, imported in the tree
> +using the update.sh script.

Please spell README correctly.

::: media/libspeex_resampler/include/Makefile.in
@@ +58,5 @@
> +endif
> +
> +EXPORTS_speex_resampler = \
> +		speex_resampler.h \
> +		$(NULL)

Again, no tabs please.

::: media/libspeex_resampler/src/Makefile.in
@@ +61,5 @@
> +
> +
> +CSRCS		= \
> +		resample.c \
> +		$(NULL)

And again.
Comment on attachment 617567 [details] [diff] [review]
Updated with AUTHORS and about:license bits

Per IRC discussion Paul is going to remove the include/src split.
Attachment #617567 - Flags: review?(khuey)
Attached patch v2 - Addressed khuey concerns (obsolete) — Splinter Review
This updated patch hopefully addresses your concerns : include/ has been merged into src/, tabs has been replaced by space in new files (I've kept tabs in files with tabs, for consistency). And I've fixed the typo in the file name.
Attachment #617567 - Attachment is obsolete: true
Attachment #618119 - Flags: review?(khuey)
Comment on attachment 618119 [details] [diff] [review]
v2 - Addressed khuey concerns

Review of attachment 618119 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libspeex_resampler/Makefile.in
@@ +1,1 @@
> +# ***** BEGIN LICENSE BLOCK *****

You should be using the new MPL2 boiler plate rather than MPL1.1 on all new source files added to the tree:

http://www.mozilla.org/MPL/headers/
Attached patch v3 - Addressed cpearce comments. (obsolete) — Splinter Review
Attachment #618119 - Attachment is obsolete: true
Attachment #618119 - Flags: review?(khuey)
Attachment #618472 - Flags: review?(khuey)
Attached patch rebased patch. (obsolete) — Splinter Review
Attachment #618472 - Attachment is obsolete: true
Attached patch Ready to land.Splinter Review
(just adding proper commit message and my name).
Attachment #622579 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b94dc0ad1c2

Also, to make life easier for those checking in patches on your behalf, please follow the directions below to make sure your patches have all the right metadata in them. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/1b94dc0ad1c2
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.