Last Comment Bug 743747 - fix bug 603514 landing
: fix bug 603514 landing
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: HTTP (show other bugs)
: 14 Branch
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on:
Blocks: 742935
  Show dependency treegraph
 
Reported: 2012-04-09 11:27 PDT by Patrick McManus [:mcmanus]
Modified: 2012-04-12 10:25 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch 0 (11.68 KB, patch)
2012-04-09 11:29 PDT, Patrick McManus [:mcmanus]
honzab.moz: review+
Details | Diff | Review

Description Patrick McManus [:mcmanus] 2012-04-09 11:27:30 PDT
603514 had merge conflicts with spdy code. The primary effect of this was I didn't merge a couple prefs that were instead left hardcoded with different default values.
Comment 1 Patrick McManus [:mcmanus] 2012-04-09 11:29:57 PDT
Created attachment 613348 [details] [diff] [review]
patch 0
Comment 2 Honza Bambas (:mayhemer) 2012-04-11 10:17:33 PDT
Comment on attachment 613348 [details] [diff] [review]
patch 0

Review of attachment 613348 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

Telemetry is the next step.

::: netwerk/protocol/http/nsHttpHandler.h
@@ +242,5 @@
> +    {
> +        return mCapabilities & NS_HTTP_ALLOW_PIPELINING;
> +    }
> +
> +    bool GetPipelineRescheduleOnTimeout()

Maybe call this GetAllowPipelineRescheduleOnTimeout()  But this way it reflects the pref..  Up to you.
Comment 3 Patrick McManus [:mcmanus] 2012-04-11 10:28:28 PDT
(In reply to Honza Bambas (:mayhemer) from comment #2)

> 
> Telemetry is the next step.
> 

yes.. probably something that tracks all the different red event types.
Comment 4 Patrick McManus [:mcmanus] 2012-04-11 10:53:05 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/e819f766c586
Comment 5 :Ehsan Akhgari (busy, don't ask for review please) 2012-04-12 10:25:33 PDT
https://hg.mozilla.org/mozilla-central/rev/e819f766c586

Note You need to log in before you can comment on or make changes to this bug.