GC: fix barriers in SupressDeletedProperties

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

14 Branch
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 613433 [details] [diff] [review]
v0

Right now, we simply stop tracing through deleted properties. This causes us to delete things that are still in the write buffer. We need to, in addition, set the reference to NULL to ensure that the write buffer doesn't dereference these dead entries.
Attachment #613433 - Flags: review?(wmccloskey)
Comment on attachment 613433 [details] [diff] [review]
v0

Review of attachment 613433 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsiter.cpp
@@ +1051,5 @@
>                          ni->props_end = ni->end() - 1;
>  
>                          /*
> +                         * This invokes the pre barrier on this element, since
> +                         * it's no longer going to be marked and ensures that

I think you want a comma between "marked" and "and".
Attachment #613433 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/053487b8f1f7
Assignee: general → terrence
Status: NEW → ASSIGNED
Version: Trunk → 14 Branch
https://hg.mozilla.org/mozilla-central/rev/053487b8f1f7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.