Closed Bug 743868 Opened 8 years ago Closed 8 years ago

GC: fix barriers in SupressDeletedProperties

Categories

(Core :: JavaScript Engine, defect)

14 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: terrence, Assigned: terrence)

References

Details

Attachments

(1 file)

Attached patch v0Splinter Review
Right now, we simply stop tracing through deleted properties. This causes us to delete things that are still in the write buffer. We need to, in addition, set the reference to NULL to ensure that the write buffer doesn't dereference these dead entries.
Attachment #613433 - Flags: review?(wmccloskey)
Comment on attachment 613433 [details] [diff] [review]
v0

Review of attachment 613433 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsiter.cpp
@@ +1051,5 @@
>                          ni->props_end = ni->end() - 1;
>  
>                          /*
> +                         * This invokes the pre barrier on this element, since
> +                         * it's no longer going to be marked and ensures that

I think you want a comma between "marked" and "and".
Attachment #613433 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/053487b8f1f7
Assignee: general → terrence
Status: NEW → ASSIGNED
Version: Trunk → 14 Branch
https://hg.mozilla.org/mozilla-central/rev/053487b8f1f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.