Last Comment Bug 743878 - Move uint8_clamped into ObjectImpl.{h,cpp}
: Move uint8_clamped into ObjectImpl.{h,cpp}
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
Mentors:
Depends on:
Blocks: 739380
  Show dependency treegraph
 
Reported: 2012-04-09 17:30 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2012-04-11 09:32 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (10.27 KB, patch)
2012-04-09 17:30 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
sphink: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2012-04-09 17:30:35 PDT
Created attachment 613447 [details] [diff] [review]
Patch

The new element-property split entails moving the typed array elements code into the base object representation.  To do that, I need access to uint8_clamped in ObjectImpl.h.  The easiest way to get that is to move the class and related methods into it.

(Technically we could do the value-clamping behavior in a different way, that didn't involve overloading operator= on a uint8_clamped struct.  That might even be preferable, for clarity, and might read more naturally if we make the typed array element-setting code slightly more split-up, rather than having it all be in a single method.  But for now, it's easiest to leave the current tricks alone and just get 'er done with the current implementation trick.)
Comment 1 Steve Fink [:sfink] [:s:] 2012-04-10 12:35:16 PDT
Comment on attachment 613447 [details] [diff] [review]
Patch

Review of attachment 613447 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. It was trivial to rebase on top of this, too, so feel free to land whenever.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2012-04-10 17:26:21 PDT
Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab4a85bc480a
Comment 3 Matt Brubeck (:mbrubeck) 2012-04-11 09:32:57 PDT
https://hg.mozilla.org/mozilla-central/rev/ab4a85bc480a

Note You need to log in before you can comment on or make changes to this bug.