743881 - IonMonkey: Handle JSOP_NEWINIT

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: Handle JSOP_NEWINIT, v1

Implements JSOP_NEWINIT as in JM, by decomposing into MNewArray or MNewObject. This is simple -- the majority of the patch addresses complications where MInitProp is created with an operand MNewObject with no baseObj, as in the JSOP_NEWINIT case.

This is handled as in JM, by always making a VM call.

Nothing subtle; pretty straightforward.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 613452 [details] [diff] [review]
Handle JSOP_NEWINIT, v1

Review of attachment 613452 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/IonBuilder.cpp
@@ +2764,4 @@
>  }
>  
>  bool
> +IonBuilder::jsop_newinit(bool isArray)

nit: This should just take a JSProtoKey instead.

Comment 2

[Jeff Walden [:Waldo]]

Noooo, no JSProtoKey!  We want to get rid of that in the long run.  Would it be too much hardship to have separate methods for the array/object cases, or something?  Anything but using JSProtoKey more.

Comment 3

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/projects/ionmonkey/rev/7899320fc29d

Since Waldo wants to remove JSProtoKey, I kept the boolean.

Comment 4

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/projects/ionmonkey/rev/72596946ff96