Last Comment Bug 743885 - Fix an OOM handling error in HashTable
: Fix an OOM handling error in HashTable
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Terrence Cole [:terrence]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-09 18:02 PDT by Terrence Cole [:terrence]
Modified: 2012-04-10 08:46 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v0 (919 bytes, patch)
2012-04-09 18:02 PDT, Terrence Cole [:terrence]
luke: review+
Details | Diff | Review
v1: With review feedback. (938 bytes, patch)
2012-04-09 19:07 PDT, Terrence Cole [:terrence]
terrence: review+
Details | Diff | Review

Description Terrence Cole [:terrence] 2012-04-09 18:02:10 PDT
Created attachment 613455 [details] [diff] [review]
v0

When I split out checkOverloaded I changed the call to changeTableSize to match that in checkUnderloaded, which ignores the result.  This is wrong.
Comment 1 Luke Wagner [:luke] 2012-04-09 18:06:52 PDT
Comment on attachment 613455 [details] [diff] [review]
v0

Could you:

  return changeTableSize(deltaLog2);
Comment 2 Terrence Cole [:terrence] 2012-04-09 19:07:55 PDT
Created attachment 613468 [details] [diff] [review]
v1: With review feedback.
Comment 3 Terrence Cole [:terrence] 2012-04-09 19:12:17 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bf10298a769
Comment 4 :Ehsan Akhgari (out sick) 2012-04-10 08:46:39 PDT
https://hg.mozilla.org/mozilla-central/rev/8bf10298a769

Note You need to log in before you can comment on or make changes to this bug.