Fix test failure misattribution for timeouts in the unix testrunner

RESOLVED FIXED in mozilla14

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 613467 [details] [diff] [review]
v0

In the unix task runner, when we kill tasks, we should be checking and returning bool if we kill, so that we then run waitpid in timeout mode.  We weren't, so tasks were never failing with timeout, only with failure.  It turns out, that this is not safe anyway, since this will race against signal delivery.  We're better off just removing this hack and letting the timeout cutoff be fuzzy.
Attachment #613467 - Flags: review?(dmandelin)
Attachment #613467 - Flags: review?(dmandelin) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/03cb4bb56621
https://hg.mozilla.org/mozilla-central/rev/03cb4bb56621
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.