As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 743896 - Fix test failure misattribution for timeouts in the unix testrunner
: Fix test failure misattribution for timeouts in the unix testrunner
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Terrence Cole [:terrence]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-04-09 18:58 PDT by Terrence Cole [:terrence]
Modified: 2012-04-12 10:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v0 (1.64 KB, patch)
2012-04-09 18:58 PDT, Terrence Cole [:terrence]
dmandelin: review+
Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2012-04-09 18:58:16 PDT
Created attachment 613467 [details] [diff] [review]

In the unix task runner, when we kill tasks, we should be checking and returning bool if we kill, so that we then run waitpid in timeout mode.  We weren't, so tasks were never failing with timeout, only with failure.  It turns out, that this is not safe anyway, since this will race against signal delivery.  We're better off just removing this hack and letting the timeout cutoff be fuzzy.
Comment 1 User image Terrence Cole [:terrence] 2012-04-11 10:04:45 PDT

Note You need to log in before you can comment on or make changes to this bug.