7439 - bad cast in appcore shutdown -> change appcores into components

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[Dan M]

nsAppCoresManager:::Shutdown static casts each of the appcores in its list of active cores to an
nsIDOMBaseAppCore, then calls Release() on the resulting pointer.  Of all our appcores, only one
of them (nsBaseAppCore) actually inherits from nsIDOMBaseAppCore.  Oddly enough, Release()
seems to be called correctly on Windows, at least for some appcores.  Other platforms are not so ...
forgiving.  They seem to just hang up after getting a wrong number.  How civilized.  Still, seems like
there's a problem here.

I'm making this a bug, rather than just fixing it, because Scott's work to change appcores into
components should neatly sidestep this problem.  So I'm ignoring it for now, but making a note...

Comment 1

[Scott Collins]

I'll take care of this as part of converting AppCores to components

Comment 2

[chris hofmann]

move to later milestone?

Comment 3

[chris hofmann]

this has moved to m8

Comment 4

[leger]

Moving all Apprunner bugs past and present to Other component temporarily whilst
don and I set correct component.  Apprunner component will be deleted/retired
shortly.

Comment 5

[Scott Collins]

Moving to M9, when the rest of this change can be checked in.

Comment 6

[leger]

Moving to M11 per today's bug triage.

Comment 7

[Scott Collins]

following bug #13021, as usual

Comment 8

[Scott Collins]

According to Bill Law in bug #13021, AppCores are no longer used (though they are
still part of the build till he gets some makefile stuff checked in).  Therefore,
this bad code in |nsAppCoresManager::Shutdown| is now dead code and so no longer
a problem.

Comment 9

[gerardok]

According to developer's comments this bug is marked as verified. If you think
the resolution is wrong please reopen.