743911 - Exception... "Security error" on www.twimbow.com

Status: RESOLVED INVALID

(Core :: Layout, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/releases/mozilla-beta/rev/9bfe6330d055
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:12.0) Gecko/20100101 Firefox/12.0 ID:20120403211507

uncaught exception: [Exception... "Security error"  code: "1000" nsresult: "0x805303e8 (NS_ERROR_DOM_SECURITY_ERR)"  location: "https://www.twimbow.com/js/TwitterUsersLoader.js Line: 634"]

Steps to reproduce:
1. Open Error console
2. Open URL.
3. Sign in

Actual results:
  uncaught exception: [Exception... "Security error"  code: "1000" nsresult: "0x805303e8 (NS_ERROR_DOM_SECURITY_ERR)"  location: "https://www.twimbow.com/js/TwitterUsersLoader.js Line: 634"]

Expected results:
  No such error

Regression window
No error:
http://hg.mozilla.org/mozilla-central/rev/9eda39f28e5a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111219 Firefox/11.0a1 ID:20111219201350
Error:
http://hg.mozilla.org/mozilla-central/rev/2afd7ae68e8b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111220 Firefox/11.0a1 ID:20111220031159
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9eda39f28e5a&tochange=2afd7ae68e8b

In local build:
Last good: 384e5cb0ffa6
First bad: 2afd7ae68e8b

Triggered by:
2afd7ae68e8b	Jason Duell — Bug 695635: Unprefix websockets. r=sicking, sr=smaug

Comment 1

[Patrick McManus [:mcmanus]]

https://www.twimbow.com/js/TwitterUsersLoader.js tries to open a websocket to ws://twimbow.com:8125 .. that's mixed content (ssl content loading non encrypted channels) - which we never allow with websockets. (and the world would have been a better place if it was never allowed in pure http.)

that's the security error.

If you set network.websocket.allowInsecureFromHTTPS you can get by that limitation, but the websocket upgrade handshake just hangs on the server (i.e. the handshake is sent and it never replies).

There isn't a regression here, its just conditional code in the javascript that never tried to use websockets until we enabled it.

Comment 2

[Alice0775 White]

is this a site issue? 
If so, is this TE bug?

Comment 3

[Patrick McManus [:mcmanus]]

(In reply to Alice0775 White from comment #2)
> is this a site issue? 
yes

> If so, is this TE bug?
could be

Comment 4

[alex_mayorga]

Is bug 743985 another manifestation of the same site issue?

Comment 6

[alex_mayorga]

Do you see increased CPU and memory usage due to this error?

I've found that when I have https://www.twimbow.com/dashboard.php loaded and active CPU creeps to 20% and "Peak Working Set" for Nightly would reach 1.5GB.

After 4 or so hours of having it pinned as an "App Tab" Nightly grinds down to a crawl.

Closing the tab brings Nightly back to a more reasonable 2% CPU and 750MB and is snappy again.

Is this expected or is there anything I could provide to improve this?

Comment 7

[alex_mayorga]

FWIW the current error that appears in error console on Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120628065213 is this:

Error: SyntaxError: An invalid or illegal string was specified
Source File: https://www.twimbow.com/js/TwitterUsersLoader.js
Line: 634

Comment 8

[alex_mayorga]

Apparently the huge memory consumption comes from https://www.twimbow.com/layer-trends.php

I'm adding [Memshrink:P?] to the whiteboard in the hopes it gets some attention from the right people.

Below a sample from Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120712030541

1,087.78 MB (100.0%) -- explicit
├────499.91 MB (45.96%) -- window-objects
│    ├──325.56 MB (29.93%) -- top(https://www.twimbow.com/dashboard.php#, id=14)/active
│    │  ├──284.12 MB (26.12%) -- window(https://www.twimbow.com/layer-trends.php?uid=6713762)
│    │  │  ├──111.82 MB (10.28%) -- layout
│    │  │  │  ├───54.10 MB (04.97%) -- frames
│    │  │  │  │   ├──28.96 MB (02.66%) ++ (7 tiny)
│    │  │  │  │   └──25.14 MB (02.31%) ── nsBlockFrame [2]
│    │  │  │  ├───35.52 MB (03.27%) ── pres-contexts [2]
│    │  │  │  ├───16.50 MB (01.52%) ── line-boxes [2]
│    │  │  │  └────5.71 MB (00.52%) ++ (5 tiny)
│    │  │  ├───90.17 MB (08.29%) -- dom
│    │  │  │   ├──46.53 MB (04.28%) ── element-nodes [2]
│    │  │  │   ├──30.02 MB (02.76%) ── orphan-nodes [2]
│    │  │  │   ├──13.57 MB (01.25%) ── text-nodes [2]
│    │  │  │   └───0.06 MB (00.01%) ── other [4]

Comment 9

[alex_mayorga]

On Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:17.0) Gecko/17.0 Firefox/17.0 ID:20120717030555

Seems about:memory is less of a concern now

│  ├───29.68 MB (06.20%) -- top(https://www.twimbow.com/dashboard.php, id=1076)/active
│  │   ├──15.63 MB (03.26%) ++ (6 tiny)
│  │   └──14.05 MB (02.93%) -- window(https://www.twimbow.com/dashboard.php)
│  │      ├───8.91 MB (01.86%) -- js/compartment(https://www.twimbow.com/dashboard.php)
│  │      │   ├──5.37 MB (01.12%) ++ gc-heap
│  │      │   └──3.54 MB (00.74%) ++ (8 tiny)
│  │      └───5.14 MB (01.07%) ++ (4 tiny)

but the page is mostly non functional due to many of these errors:

Error: SecurityError: The operation is insecure.
Source File: https://www.twimbow.com/js/twimbow.classes.js
Line: 308

Comment 10

[Alice0775 White]

404 error