Don't keep history in memory during Profile Migration

RESOLVED FIXED in Firefox 14

Status

()

Firefox for Android
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gcp, Assigned: gcp)

Tracking

Trunk
Firefox 14
ARM
Android
Points:
---

Firefox Tracking Flags

(blocking-fennec1.0 beta+)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Profile Migration still contains code to gracefully merge the history from when it was merging places into the Android DB. It remember the original history entries and uses the more recent date of places|Android entries.

We no longer use the Android database, so this isn't needed, and starting from bug 736237 we can now potentially create a history database of hundreds of thousands of entries. This old code needs to go so we don't slow down/OOM.
(Assignee)

Updated

6 years ago
Assignee: nobody → gpascutto
(Assignee)

Comment 1

6 years ago
Created attachment 613994 [details] [diff] [review]
Patch 1. Don't get history in memory when migrating
Attachment #613994 - Flags: review?(lucasr.at.mozilla)
(Assignee)

Updated

6 years ago
Blocks: 721898
(Assignee)

Comment 2

6 years ago
Created attachment 614201 [details] [diff] [review]
Patch 1. v2 Don't get history in memory when migrating

History.DATE_LAST_ADDED was missing from the projection, which caused updating existing entries to fail.
Attachment #613994 - Attachment is obsolete: true
Attachment #613994 - Flags: review?(lucasr.at.mozilla)
Attachment #614201 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 614201 [details] [diff] [review]
Patch 1. v2 Don't get history in memory when migrating

Review of attachment 614201 [details] [diff] [review]:
-----------------------------------------------------------------

This bug is not a blocker right now. Nom it? This code desperately needs tests!
Attachment #614201 - Flags: review?(lucasr.at.mozilla) → review+
blocking-fennec1.0: --- → beta+
https://hg.mozilla.org/mozilla-central/rev/d0c617586fcf
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.