Closed Bug 743923 Opened 8 years ago Closed 8 years ago

Don't keep history in memory during Profile Migration

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
blocking-fennec1.0 --- beta+

People

(Reporter: gcp, Assigned: gcp)

References

Details

Attachments

(1 file, 1 obsolete file)

Profile Migration still contains code to gracefully merge the history from when it was merging places into the Android DB. It remember the original history entries and uses the more recent date of places|Android entries.

We no longer use the Android database, so this isn't needed, and starting from bug 736237 we can now potentially create a history database of hundreds of thousands of entries. This old code needs to go so we don't slow down/OOM.
Assignee: nobody → gpascutto
Attachment #613994 - Flags: review?(lucasr.at.mozilla)
Blocks: 721898
History.DATE_LAST_ADDED was missing from the projection, which caused updating existing entries to fail.
Attachment #613994 - Attachment is obsolete: true
Attachment #613994 - Flags: review?(lucasr.at.mozilla)
Attachment #614201 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 614201 [details] [diff] [review]
Patch 1. v2 Don't get history in memory when migrating

Review of attachment 614201 [details] [diff] [review]:
-----------------------------------------------------------------

This bug is not a blocker right now. Nom it? This code desperately needs tests!
Attachment #614201 - Flags: review?(lucasr.at.mozilla) → review+
blocking-fennec1.0: --- → beta+
https://hg.mozilla.org/mozilla-central/rev/d0c617586fcf
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
You need to log in before you can comment on or make changes to this bug.