743923 - Don't keep history in memory during Profile Migration

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gian-Carlo Pascutto [:gcp]]

Profile Migration still contains code to gracefully merge the history from when it was merging places into the Android DB. It remember the original history entries and uses the more recent date of places|Android entries.

We no longer use the Android database, so this isn't needed, and starting from bug 736237 we can now potentially create a history database of hundreds of thousands of entries. This old code needs to go so we don't slow down/OOM.

Comment 1

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Don't get history in memory when migrating

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. v2 Don't get history in memory when migrating

History.DATE_LAST_ADDED was missing from the projection, which caused updating existing entries to fail.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 614201 [details] [diff] [review]
Patch 1. v2 Don't get history in memory when migrating

Review of attachment 614201 [details] [diff] [review]:
-----------------------------------------------------------------

This bug is not a blocker right now. Nom it? This code desperately needs tests!

Comment 4

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0c617586fcf

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d0c617586fcf