B2G Wifi: More small cleanup

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I have a small patch here that does the following:
- Always updates dhcpInfo so that it's more likely to be correct.
- Updates manager.connectionInfo.id to be correct in more places.
- Moves connection logic out of the wifi manager and into the code that does the rest of the connection logic stuff. The idea is that the WifiManager is responsible for sending notifications and holds a bit of state while the actual logic for controlling the supplicant lives in the WifiController. I fear that this is always going to be a leaky abstraction, but at least it'll help group the related code together.
(Assignee)

Comment 1

5 years ago
Created attachment 613531 [details] [diff] [review]
Proposed fix
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #613531 - Flags: review?(jones.chris.g)
Attachment #613531 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7086b25fac2e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.