Closed Bug 743941 Opened 13 years ago Closed 13 years ago

B2G Wifi: More small cleanup

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: mrbkap, Assigned: mrbkap)

References

Details

Attachments

(1 file)

Proposed fix
5.18 KB, patch
cjones
: review+
Details | Diff | Splinter Review 
I have a small patch here that does the following:
- Always updates dhcpInfo so that it's more likely to be correct.
- Updates manager.connectionInfo.id to be correct in more places.
- Moves connection logic out of the wifi manager and into the code that does the rest of the connection logic stuff. The idea is that the WifiManager is responsible for sending notifications and holds a bit of state while the actual logic for controlling the supplicant lives in the WifiController. I fear that this is always going to be a leaky abstraction, but at least it'll help group the related code together.
Attached patch Proposed fix — — Splinter Review 

  

  


Assignee: nobody → mrbkap
Status: NEW → ASSIGNED

        Attachment #613531 -
        Flags: review?(jones.chris.g)

        Attachment #613531 -
        Flags: review?(jones.chris.g) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7086b25fac2e

  

  


Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: