Last Comment Bug 743941 - B2G Wifi: More small cleanup
: B2G Wifi: More small cleanup
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Blake Kaplan (:mrbkap)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: b2g-wifi
  Show dependency treegraph
 
Reported: 2012-04-10 02:51 PDT by Blake Kaplan (:mrbkap)
Modified: 2012-04-13 01:38 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Proposed fix (5.18 KB, patch)
2012-04-10 02:55 PDT, Blake Kaplan (:mrbkap)
cjones.bugs: review+
Details | Diff | Splinter Review

Description Blake Kaplan (:mrbkap) 2012-04-10 02:51:50 PDT
I have a small patch here that does the following:
- Always updates dhcpInfo so that it's more likely to be correct.
- Updates manager.connectionInfo.id to be correct in more places.
- Moves connection logic out of the wifi manager and into the code that does the rest of the connection logic stuff. The idea is that the WifiManager is responsible for sending notifications and holds a bit of state while the actual logic for controlling the supplicant lives in the WifiController. I fear that this is always going to be a leaky abstraction, but at least it'll help group the related code together.
Comment 1 Blake Kaplan (:mrbkap) 2012-04-10 02:55:13 PDT
Created attachment 613531 [details] [diff] [review]
Proposed fix
Comment 2 Blake Kaplan (:mrbkap) 2012-04-13 01:38:29 PDT
https://hg.mozilla.org/mozilla-central/rev/7086b25fac2e

Note You need to log in before you can comment on or make changes to this bug.