744355 - Add marketplace.firefox.com to the xpinstall whitelist

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Justin Scott [:fligtar]]

Later this year, the consumer-facing portions of AMO will move into the new Mozilla Marketplace, and add-on and theme (Persona) installations will take place there instead of AMO.

We'd like to add marketplace.mozilla.org to the whitelist so that users will have it ready to go when that happens, currently planned for around September but possibly earlier.

Comment 1

[Justin Scott [:fligtar]]

Note: this URL now needs to be marketplace.firefox.com.

We're planning to migrate themes (Personas) to Marketplace pretty soon -- can we get this added so it's in a stable release in the next couple months?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Ignoring mobile XUL, as that's EOL. Ignoring Metro-fx, as that doesn't support addons/backgrounds yet. And ignoring B2G, as that doesn't use the Add-ons Manager for anything other than testing.

The convention is to use the app version the whitelist entry was added in, so I'm assuming this will get approved for Beta (18). I'll hold off on landing on m-c until this gets approval to land there, otherwise things will get confusing (and I'll hold off requesting approval until it gets r+/f+).

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Fligtar: Is getpersonas.com getting retired? Is that happening anytime soon?

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note to self: This needs to go on ESR too.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to Blair McBride (:Unfocused) from comment #3)
> Fligtar: Is getpersonas.com getting retired? Is that happening anytime soon?

There is no EOL date yet.  So, yes, for some values of soon.  We should leave it in the list for now.

Comment 6

[Justin Scott [:fligtar]]

Comment on attachment 683361 [details] [diff] [review]
Patch v1

Thanks!

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 683361 [details] [diff] [review]
Patch v1

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: (From comment 0:) The consumer-facing portions of AMO will move into the new Mozilla Marketplace, and add-on and theme (Persona) installations will take place there instead of AMO. That URL needs to be whitelisted so addon installation works the same as it currently does with addons.mozilla.org. ESR is a bit special, as the switchover is planned to occur before the next major ESR release - so it needs done in a dot-release instead.
User impact if declined: Unable to install addons without being first prompted to manually add the URL to the whitelist.
Fix Landed on Version: None yet - patch contains a version string for when this first lands, so need approval before landing anywhere (eg, if approval is denied for beta, the patch will need to be updated).
Risk to taking this patch (and alternatives if risky): Near-zero. We rarely ever add things to the whitelist, but it's well tested and the code that handles this is run every time a new profile is created. 
String or UUID changes made by this patch: None

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 683361 [details] [diff] [review]
Patch v1

Approving for branches in support of the theme move.

Comment 9

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-esr17
https://hg.mozilla.org/releases/mozilla-esr17/rev/03cd94f910ad

Pushed to mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/73aa34f747b4

Pushed to mozilla-aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/3da7d46830ac

Comment 10

[Dave Townsend [:mossop]]

And to top it off: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ea358b798fe

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1ea358b798fe