744366 - Assert about expected readyState before readyState transitions

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Henri Sivonen (:hsivonen)]

In order to make it easier to fix about:blank in a way that makes sure its readyStates are reasonable, it's useful to assert about the readyState being transitioned away from in various situations. (However, it's probably not worthwhile to try to make readyState make sense for XUL documents.) In order to avoid bitrot, it makes sense to do this separately of the main about:blank fix.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Assert about readyState

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Assert about readyState, right patch

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 615379 [details] [diff] [review]
Assert about readyState, right patch

Review of attachment 615379 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +7707,5 @@
> +  /*
> +  if (READYSTATE_COMPLETE == rs) {
> +    fprintf(stderr, "Setting readyState to complete on %p\n", static_cast<nsIDocument*>(this));
> +    NS_ASSERTION(false, "Dump stack");
> +  }

You probably want to remove this hunk before landing.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 615379 [details] [diff] [review]
Assert about readyState, right patch

What ms2ger said, and r=me

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Ms2ger from comment #3)
> You probably want to remove this hunk before landing.

Oops. Thanks. Removed.

(In reply to Boris Zbarsky (:bz) from comment #4)
> What ms2ger said, and r=me

Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed1eb2bb418

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5ed1eb2bb418