Last Comment Bug 744366 - Assert about expected readyState before readyState transitions
: Assert about expected readyState before readyState transitions
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Document Navigation (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Henri Sivonen (:hsivonen)
:
Mentors:
Depends on: 746880
Blocks: sync-about-blank
  Show dependency treegraph
 
Reported: 2012-04-11 05:10 PDT by Henri Sivonen (:hsivonen)
Modified: 2012-04-18 21:42 PDT (History)
4 users (show)
hsivonen: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Assert about readyState (1.64 KB, patch)
2012-04-16 08:00 PDT, Henri Sivonen (:hsivonen)
no flags Details | Diff | Review
Assert about readyState, right patch (11.38 KB, patch)
2012-04-16 10:31 PDT, Henri Sivonen (:hsivonen)
bzbarsky: review+
Details | Diff | Review

Description Henri Sivonen (:hsivonen) 2012-04-11 05:10:21 PDT
In order to make it easier to fix about:blank in a way that makes sure its readyStates are reasonable, it's useful to assert about the readyState being transitioned away from in various situations. (However, it's probably not worthwhile to try to make readyState make sense for XUL documents.) In order to avoid bitrot, it makes sense to do this separately of the main about:blank fix.
Comment 1 Henri Sivonen (:hsivonen) 2012-04-16 08:00:35 PDT
Created attachment 615335 [details] [diff] [review]
Assert about readyState
Comment 2 Henri Sivonen (:hsivonen) 2012-04-16 10:31:55 PDT
Created attachment 615379 [details] [diff] [review]
Assert about readyState, right patch
Comment 3 :Ms2ger 2012-04-16 10:40:43 PDT
Comment on attachment 615379 [details] [diff] [review]
Assert about readyState, right patch

Review of attachment 615379 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +7707,5 @@
> +  /*
> +  if (READYSTATE_COMPLETE == rs) {
> +    fprintf(stderr, "Setting readyState to complete on %p\n", static_cast<nsIDocument*>(this));
> +    NS_ASSERTION(false, "Dump stack");
> +  }

You probably want to remove this hunk before landing.
Comment 4 Boris Zbarsky [:bz] (Out June 25-July 6) 2012-04-16 12:14:56 PDT
Comment on attachment 615379 [details] [diff] [review]
Assert about readyState, right patch

What ms2ger said, and r=me
Comment 5 Henri Sivonen (:hsivonen) 2012-04-16 23:44:04 PDT
(In reply to Ms2ger from comment #3)
> You probably want to remove this hunk before landing.

Oops. Thanks. Removed.

(In reply to Boris Zbarsky (:bz) from comment #4)
> What ms2ger said, and r=me

Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed1eb2bb418
Comment 6 Marco Bonardo [::mak] 2012-04-17 07:52:57 PDT
https://hg.mozilla.org/mozilla-central/rev/5ed1eb2bb418

Note You need to log in before you can comment on or make changes to this bug.