Assert about expected readyState before readyState transitions

RESOLVED FIXED in mozilla14

Status

()

Core
Document Navigation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Trunk
mozilla14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In order to make it easier to fix about:blank in a way that makes sure its readyStates are reasonable, it's useful to assert about the readyState being transitioned away from in various situations. (However, it's probably not worthwhile to try to make readyState make sense for XUL documents.) In order to avoid bitrot, it makes sense to do this separately of the main about:blank fix.
(Assignee)

Comment 1

5 years ago
Created attachment 615335 [details] [diff] [review]
Assert about readyState
(Assignee)

Comment 2

5 years ago
Created attachment 615379 [details] [diff] [review]
Assert about readyState, right patch
Attachment #615335 - Attachment is obsolete: true
Attachment #615379 - Flags: review?(bzbarsky)
Comment on attachment 615379 [details] [diff] [review]
Assert about readyState, right patch

Review of attachment 615379 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsDocument.cpp
@@ +7707,5 @@
> +  /*
> +  if (READYSTATE_COMPLETE == rs) {
> +    fprintf(stderr, "Setting readyState to complete on %p\n", static_cast<nsIDocument*>(this));
> +    NS_ASSERTION(false, "Dump stack");
> +  }

You probably want to remove this hunk before landing.
Comment on attachment 615379 [details] [diff] [review]
Assert about readyState, right patch

What ms2ger said, and r=me
Attachment #615379 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Ms2ger from comment #3)
> You probably want to remove this hunk before landing.

Oops. Thanks. Removed.

(In reply to Boris Zbarsky (:bz) from comment #4)
> What ms2ger said, and r=me

Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed1eb2bb418
Flags: in-testsuite-
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/5ed1eb2bb418
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 746880
You need to log in before you can comment on or make changes to this bug.