7444 - [DOGFOOD]Should not have to require passwords be displayed in prefs.js file

Status: VERIFIED FIXED

(MailNews Core :: Networking, defect, P3)

Description

[lchiang]

Should not have to require passwords be displayed in prefs50.js file

Since this is such an important item, I'm entering a placeholder bug for this
even though you may not have implemented this yet.

Definitely before the first public beta, we should not require that the user
type out his/her mail password in the prefs50.js file.  We should prompt the
user with a password dialog at the appropriate time(s).

Comment 1

[leger]

Moving all Mail/News Networking bugs to Mail/News Networking-Mail

This may re-open previously Verified bugs due to a Bugzilla bug...if so, I will
fix those bugs.

Comment 2

[lchiang]

Is M11 after the first beta?  Is this an acceptable thing to have in a beta?

Comment 3

[Scott MacGregor]

Your right...I was too hasty. This does need resolved before the first beta.

Changing back to M10.

Comment 4

[Scott MacGregor]

Okay, it looks like dialogs are working today!

I've gone ahead and checked in code for POP (not imap yet) which does the
following:

When you hit get new messages, we bring up a prompt for password dialog. You can
enter your password here. I no longer look at the password preference at all. So
you should be able to delete that pref and still be able to use get new mail.

I'm not going to close this bug yet though because the following things still
need to happen:
1) we need to hook it up for imap
2) we need to hook up remember password
3) we need to remember the password for the current session. Right now I prompt
every time you hit get new messages.

Comment 5

[lchiang]

Do you also display an error if the wrong password has been entered and not
accepted by the server?

Comment 6

[Scott MacGregor]

Not yet...this is more indicative of us not having any alerts in the mailnews
product yet rather than a prompt for password dialog.

I'll add it to the list of things we need to do before I close off this bug.

Comment 7

[sol]

Definitely needs to be fixed by PR1, so I added a note in the Status Whiteboard

Comment 8

[David :Bienvenu]

I believe this all basically works for imap - you'll get a login failed alert,
and get re-prompted for your password.

Comment 9

[Scott MacGregor]

(2) is the only thing left keeping this bug open.

Comment 10

[Scott MacGregor]

I've checked in a lot of changes to the password dialog tonight that effet both
imap and pop. As part of these changes, pop now respects the remember_password
field (which does get migrated if you migrate a 4.5 profile).

If you've already migrated a profile, you need to set this pref manually:
user_pref("mail.server.server1.remember_password", true);

The following steps are written for pop but the same functionality is there for
imap as well so we need to QA both of them.

0) make sure you don't have a .password pref containing your password for the
server you are going to test.
1) Set the pref I listed above for a pop and an imap account
2) run seamonkey and hit get new messages for the server you set the pref on.
3) You should be prompted for a password. Enter it here.
4) Verify that new messages are retrieved.
5) hit get new mail again.
6) Verify that we remembered your password for the *session*.
7) Now quit seamonkey.

Okay now we're going to test remember password...
8) Start seamonkey again and select the same account you already entered a
password for
9) hit get new messages.
10) Verify that we don't ask you for your password (it should be stored in your
prefs now).

Other things to verify:
Enter an incorrect password, try to use it and make sure we don't remember the
incorrect one.

Make sure that biff only works if remember password is turned on and you've
already entered your password so it is stored in preferences.

Make sure that biff works if you don't have remember password turned on but you
have entered a password for the server during the current session.

These tests apply to both imap and pop.

Comment 11

[esther]

Using 1999100320M10 on win98, 1999100118M10 on linux and 1999100120M10 on Mac
this has been partially verified.  Number 1& 3 are verified, #2 still needs to
be verified, but bug 15705 (remembered password not getting written to
prefs.js file) has to be fixed first.  The Other things listed above have to be
verified after the fix for 15705.  Will keep this opened until that fix goes in.

Comment 12

[esther]

Using 1999100617M10 commercial build on win98 and 1999100615M10 commercial build
on mac #2 and "Other things" now work OK.   Thanks Seth! Waiting for linux to
verify for that platform.

Comment 13

[fenella]

Linux (1999-10-07-16 M10)
I did all 10 steps on IMAP. It works fine. But I cannot do it on POP because it
display ! and _ in the login prompt

Comment 14

[fenella]

Linux Redhat 6.0 (1999-11-01-08 M11)
I tried it on POP. It works fine too.