744409 - talos results are stored as a tuple and should be stored as an object

Status: RESOLVED DUPLICATE of bug 755527

(Testing :: Talos, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

currently we shove all our result related information into a tuple like this:
results[testname] = [browser_dump, counter_dump, print_format, test]

I think we could use the AnalyzeThis! and filters.py toolchain to handle this better.  I see 4 spots to really clean up code:
http://hg.mozilla.org/build/talos/file/70b5bf52cf88/talos/ttest.py#l420
http://hg.mozilla.org/build/talos/file/70b5bf52cf88/talos/run_tests.py#l118
http://hg.mozilla.org/build/talos/file/70b5bf52cf88/talos/run_tests.py#l229
http://hg.mozilla.org/build/talos/file/70b5bf52cf88/talos/run_tests.py#l597

Comment 1

[Jeff Hammel]

https://bugzilla.mozilla.org/show_bug.cgi?id=755527 contains the metaissue

Comment 2

[Burak Yiğit Kaya [:BYK]]

What about named tuples?

Comment 3

[Jeff Hammel]

I'd much prefer a real class.  Not only are we passing a bunch of stuff around all over the place, but we have logic all over the place for dealing with the different types of results (ts, tp, amo).  I'd much prefer to consolidate this logic in a few classes as briefly outlined in bug 755527 .  In fact, I'm going to dup against that.