Note: There are a few cases of duplicates in user autocompletion which are being worked on.

B2G Wifi: better nsIDOMWifiManager.forgetNetwork function

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 614009 [details] [diff] [review]
patch proposal

The current `forgetNetwork' implementation is buggy because it couldn’t be tested so far.

Here’s a quick fix that works with my current Gaia tree:
https://github.com/fabi1cazenave/gaia/tree/wifi
(Assignee)

Comment 1

5 years ago
mrbkap > for my information, what’s the difference between

    var request = this.createRequest();

and

    var request = Services.DOMRequest.createRequest(this._window);

? In DOMWifiManager.js, the latter is only used for `forget' — the former is used everywhere else.
Comment on attachment 614009 [details] [diff] [review]
patch proposal

The two versions of createRequest are equivalent. Please do change the one in forget for consistency though.

Thanks a lot and sorry for the typos!
Attachment #614009 - Flags: review+
(Assignee)

Comment 3

5 years ago
Created attachment 614042 [details] [diff] [review]
patch proposal

same patch, now using `this.createRequest()' for better consistency.
Attachment #614009 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
Created attachment 614043 [details] [diff] [review]
patch proposal

sorry, did a `git diff >> patch' instead of a `git diff > patch'.
Assignee: nobody → kaze
Attachment #614042 - Attachment is obsolete: true
Blocks: 717123
Summary: [wifi] better nsIDOMWifiManager.forgetNetwork function → B2G Wifi: better nsIDOMWifiManager.forgetNetwork function
https://hg.mozilla.org/mozilla-central/rev/63a7d74d01d8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.