744417 - B2G Wifi: better nsIDOMWifiManager.forgetNetwork function

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

The current `forgetNetwork' implementation is buggy because it couldn’t be tested so far.

Here’s a quick fix that works with my current Gaia tree:
https://github.com/fabi1cazenave/gaia/tree/wifi

Comment 1

[Fabien Cazenave [:kaze]]

mrbkap > for my information, what’s the difference between

    var request = this.createRequest();

and

    var request = Services.DOMRequest.createRequest(this._window);

? In DOMWifiManager.js, the latter is only used for `forget' — the former is used everywhere else.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 614009 [details] [diff] [review]
patch proposal

The two versions of createRequest are equivalent. Please do change the one in forget for consistency though.

Thanks a lot and sorry for the typos!

Comment 3

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

same patch, now using `this.createRequest()' for better consistency.

Comment 4

[Fabien Cazenave [:kaze]]

Attachment: patch proposal

sorry, did a `git diff >> patch' instead of a `git diff > patch'.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/mozilla-central/rev/63a7d74d01d8