74446 - Extra dot appearing at the beginning of lines in the body

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[Navin Gupta]

If you send a text/plain message with body as

.dsfgfdgfd
.gfdsgsfdgfds
.sgfdgfdgdsgfdgsd

You end up receiving 

..dsfgfdgfd
..gfdsgsfdgfds
..sgfdgfdgdsgfdgsd

Comment 1

[Navin Gupta]

Attachment: proposed fix. Explanation in the patch

Comment 2

[Navin Gupta]

Need r/sr

Comment 3

[David :Bienvenu]

was this broken in 6.0? I thought it worked at some point. Your change looks OK,
but I'm worried that this regressed for some other reason...

Comment 4

[Navin Gupta]

I can reproduce this on 6.0 & 6.01 RTM. This does not seem to be a regression.

Comment 5

[David :Bienvenu]

ok sr=bienvenu

Comment 6

[Navin Gupta]

Attachment: revised patch

Comment 7

[David :Bienvenu]

does the second patch avoid writing the terminal "."CRLF to the folder via
incorporate write? It looks to me like we do still write that terminal .CRLF.
And now that we don't handline it in IncorporateWrite, we need to not write it.

Comment 8

[Navin Gupta]

We don't write it anymore because we check for termination before we pass it 
to IncorporateWrite

     if ((line[0] == '.') &&
         ((line[1] == CR) || (line[1] == LF)))
@@ -2429,6 +2425,25 @@
             m_pop3ConData->msg_closure = 0;

Comment 9

[David :Bienvenu]

How does that make IncorporateWrite not get called? I don't think the pop3 sink
knows anything about the msg_closure.

Comment 10

[Navin Gupta]

Attachment: revised patch. Nice catch !!!

Comment 11

[David :Bienvenu]

sr=bienvenu - before checking in, you should run a few tests and look at the
berkeley mailbox with a text editor to make sure the messages look OK - check
that .. lines from the server look like . in the folder, and that we don't have
a trailing "." line, and that we get all of the message when we have '.''s
escaped, e.g., try a message like
foo
.
.
.
.
bar

and make sure it is received correctly in the local berkeley mailbox.

Comment 12

[Navin Gupta]

ested the above case and checked the berkeley mailbox (inbox) and there was
no extra . at the end. 

fix checked in

Comment 13

[laurel]

OK using apr4 commercial trunk build, win98.

Comment 14

[Mike Cowperthwaite]

*** Bug 67971 has been marked as a duplicate of this bug. ***