Closed
Bug 74446
Opened 23 years ago
Closed 23 years ago
Extra dot appearing at the beginning of lines in the body
Categories
(MailNews Core :: Networking: POP, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: naving, Assigned: naving)
References
Details
Attachments
(3 files)
1.33 KB,
patch
|
Details | Diff | Splinter Review | |
2.97 KB,
patch
|
Details | Diff | Splinter Review | |
3.05 KB,
patch
|
Details | Diff | Splinter Review |
If you send a text/plain message with body as .dsfgfdgfd .gfdsgsfdgfds .sgfdgfdgdsgfdgsd You end up receiving ..dsfgfdgfd ..gfdsgsfdgfds ..sgfdgfdgdsgfdgsd
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Need r/sr
Comment 3•23 years ago
|
||
was this broken in 6.0? I thought it worked at some point. Your change looks OK, but I'm worried that this regressed for some other reason...
Assignee | ||
Comment 4•23 years ago
|
||
I can reproduce this on 6.0 & 6.01 RTM. This does not seem to be a regression.
Comment 5•23 years ago
|
||
ok sr=bienvenu
Assignee | ||
Comment 6•23 years ago
|
||
Comment 7•23 years ago
|
||
does the second patch avoid writing the terminal "."CRLF to the folder via incorporate write? It looks to me like we do still write that terminal .CRLF. And now that we don't handline it in IncorporateWrite, we need to not write it.
Assignee | ||
Comment 8•23 years ago
|
||
We don't write it anymore because we check for termination before we pass it to IncorporateWrite if ((line[0] == '.') && ((line[1] == CR) || (line[1] == LF))) @@ -2429,6 +2425,25 @@ m_pop3ConData->msg_closure = 0;
Comment 9•23 years ago
|
||
How does that make IncorporateWrite not get called? I don't think the pop3 sink knows anything about the msg_closure.
Assignee | ||
Comment 10•23 years ago
|
||
Comment 11•23 years ago
|
||
sr=bienvenu - before checking in, you should run a few tests and look at the berkeley mailbox with a text editor to make sure the messages look OK - check that .. lines from the server look like . in the folder, and that we don't have a trailing "." line, and that we get all of the message when we have '.''s escaped, e.g., try a message like foo . . . . bar and make sure it is received correctly in the local berkeley mailbox.
Assignee | ||
Comment 12•23 years ago
|
||
ested the above case and checked the berkeley mailbox (inbox) and there was no extra . at the end. fix checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: MailNews → Core
Comment 14•18 years ago
|
||
*** Bug 67971 has been marked as a duplicate of this bug. ***
Updated•15 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•