744495 - XulRunner candidate builds don't set product property and inherit default 'firefox' value

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Seen today when implementing the Mozilla CI solution for beta candidate builds. Some XulRunner builders do not have the right product set in the properties, so Pulse gives us a false information with product='firefox' when testing Firefox builds only.

{
  u'toolsdir': u'/builds/slave/rel-m-beta-xr-lnx-bld/tools',
  u'got_revision': u'4b1d4ddf1fb4',
  u'forced_clobber': False,
  u'purge_actual': u'7.07GB',
  u'buildnumber': 54,
  u'build_number': 1,
  u'builddir': u'rel-m-beta-xr-lnx-bld',
  u'slavename': u'moz2-linux-slave41',
  u'basedir': u'/builds/slave/rel-m-beta-xr-lnx-bld',
  u'comments': '',
  u'purge_target': u'6GB',
  u'platform': u'linux',
  u'version': u'12.0b5',
  u'master': u'http://buildbot-master08.build.sjc1.mozilla.com:8001/',
  u'branch': u'release-mozilla-beta',
  u'revision': u'None',
  u'product': u'firefox',
  u'repository': '',
  u'buildername': u'release-mozilla-beta-xulrunner_linux_build',
  u'buildid': u'20120411064248',
  u'hashType': u'sha512',
  u'scheduler': u'release-mozilla-beta-firefox_build',
  u'packageUrl': u'http://stage.mozilla.org/pub/mozilla.org/xulrunner/nightly/12.0b5-candidates/build1/runtimes/xulrunner-12.0b5.en-US.linux-i686.tar.bz2',
  u'script_repo_revision': u'FIREFOX_12_0b5_RELEASE',
  u'purged_clobber': True,
  u'project': '',
  u'products': u'firefox,fennec',
  u'periodic_clobber': False,
  u'builduid': u'ae96c870ec57466da51776ae36106ca6',
  u'slavebuilddir': u'rel-m-beta-xr-lnx-bld'
}

As given by Chris we have to add the product property here:
http://hg.mozilla.org/build/buildbotcustom/file/default/process/release.py#l852

I will work on it right now. Expect a patch shortly.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1

So I have updated two entries for the xulrunner build config. One for the real builds and another for the dummy xulrunner builds. I think that both should identify themselves as xulrunner product.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

http://hg.mozilla.org/build/buildbotcustom/rev/d306e78bcec2